Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3023)

Unified Diff: content/shell/test_runner/test_runner.h

Issue 2963593002: Split DumpPixelsAsync in pixel_dump.h into more granular functions. (Closed)
Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/test_runner/pixel_dump.cc ('k') | content/shell/test_runner/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/test_runner/test_runner.h
diff --git a/content/shell/test_runner/test_runner.h b/content/shell/test_runner/test_runner.h
index 02d978fc8253e2ae3b55cd0a0a9f90614af3c380..739d6de9c4f4b6e16609d5f17d42caea9ae0e9e8 100644
--- a/content/shell/test_runner/test_runner.h
+++ b/content/shell/test_runner/test_runner.h
@@ -93,8 +93,8 @@ class TestRunner : public WebTestRunner {
bool IsRecursiveLayoutDumpRequested() override;
std::string DumpLayout(blink::WebLocalFrame* frame) override;
void DumpPixelsAsync(
- blink::WebView* web_view,
- const base::Callback<void(const SkBitmap&)>& callback) override;
+ blink::WebLocalFrame* frame,
+ base::OnceCallback<void(const SkBitmap&)> callback) override;
void ReplicateLayoutTestRuntimeFlagsChanges(
const base::DictionaryValue& changed_values) override;
bool HasCustomTextDump(std::string* custom_text_dump) const override;
« no previous file with comments | « content/shell/test_runner/pixel_dump.cc ('k') | content/shell/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698