Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: content/shell/test_runner/test_runner.h

Issue 2963593002: Split DumpPixelsAsync in pixel_dump.h into more granular functions. (Closed)
Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/test_runner/pixel_dump.cc ('k') | content/shell/test_runner/test_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_ 5 #ifndef CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_
6 #define CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_ 6 #define CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <deque> 10 #include <deque>
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 bool UseMockTheme() const { return use_mock_theme_; } 87 bool UseMockTheme() const { return use_mock_theme_; }
88 88
89 // WebTestRunner implementation. 89 // WebTestRunner implementation.
90 bool ShouldGeneratePixelResults() override; 90 bool ShouldGeneratePixelResults() override;
91 bool ShouldDumpAsAudio() const override; 91 bool ShouldDumpAsAudio() const override;
92 void GetAudioData(std::vector<unsigned char>* buffer_view) const override; 92 void GetAudioData(std::vector<unsigned char>* buffer_view) const override;
93 bool IsRecursiveLayoutDumpRequested() override; 93 bool IsRecursiveLayoutDumpRequested() override;
94 std::string DumpLayout(blink::WebLocalFrame* frame) override; 94 std::string DumpLayout(blink::WebLocalFrame* frame) override;
95 void DumpPixelsAsync( 95 void DumpPixelsAsync(
96 blink::WebView* web_view, 96 blink::WebLocalFrame* frame,
97 const base::Callback<void(const SkBitmap&)>& callback) override; 97 base::OnceCallback<void(const SkBitmap&)> callback) override;
98 void ReplicateLayoutTestRuntimeFlagsChanges( 98 void ReplicateLayoutTestRuntimeFlagsChanges(
99 const base::DictionaryValue& changed_values) override; 99 const base::DictionaryValue& changed_values) override;
100 bool HasCustomTextDump(std::string* custom_text_dump) const override; 100 bool HasCustomTextDump(std::string* custom_text_dump) const override;
101 bool ShouldDumpBackForwardList() const override; 101 bool ShouldDumpBackForwardList() const override;
102 blink::WebContentSettingsClient* GetWebContentSettings() const override; 102 blink::WebContentSettingsClient* GetWebContentSettings() const override;
103 blink::WebTextCheckClient* GetWebTextCheckClient() const override; 103 blink::WebTextCheckClient* GetWebTextCheckClient() const override;
104 void InitializeWebViewWithMocks(blink::WebView* web_view) override; 104 void InitializeWebViewWithMocks(blink::WebView* web_view) override;
105 void SetFocus(blink::WebView* web_view, bool focus) override; 105 void SetFocus(blink::WebView* web_view, bool focus) override;
106 106
107 // Methods used by WebViewTestClient and WebFrameTestClient. 107 // Methods used by WebViewTestClient and WebFrameTestClient.
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 bool disable_v8_cache_ = false; 659 bool disable_v8_cache_ = false;
660 660
661 base::WeakPtrFactory<TestRunner> weak_factory_; 661 base::WeakPtrFactory<TestRunner> weak_factory_;
662 662
663 DISALLOW_COPY_AND_ASSIGN(TestRunner); 663 DISALLOW_COPY_AND_ASSIGN(TestRunner);
664 }; 664 };
665 665
666 } // namespace test_runner 666 } // namespace test_runner
667 667
668 #endif // CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_ 668 #endif // CONTENT_SHELL_TEST_RUNNER_TEST_RUNNER_H_
OLDNEW
« no previous file with comments | « content/shell/test_runner/pixel_dump.cc ('k') | content/shell/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698