Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2963523003: Add StrictMode exemption from getDrawable. (Closed)

Created:
3 years, 5 months ago by Ted C
Modified:
3 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add StrictMode exemption from getDrawable. Long, long, mythical likely never to arise time, we should look at not calling this on the UI thread and loading images in the background, but the usage of this is wide spread and would likely need a bunch of work to get there. For now, we can whitelist this call to allow disk reads to not pollute our strict mode reports. BUG=680089 Review-Url: https://codereview.chromium.org/2963523003 Cr-Commit-Position: refs/heads/master@{#482677} Committed: https://chromium.googlesource.com/chromium/src/+/a96a27ea07c9938b63205d83e91a4dbb7afaea7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 5 months ago (2017-06-27 16:30:35 UTC) #2
Yaron
On 2017/06/27 16:30:35, Ted C wrote: > PTAL lgtm
3 years, 5 months ago (2017-06-27 16:53:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963523003/1
3 years, 5 months ago (2017-06-27 16:55:39 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:52:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a96a27ea07c9938b63205d83e91a...

Powered by Google App Engine
This is Rietveld 408576698