Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2962703002: [Telemetry] Delete discover shim (Closed)

Created:
3 years, 5 months ago by eakuefner
Modified:
3 years, 5 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Delete discover shim Now that references will have been updated on the Chromium side as of https://codereview.chromium.org/2958093002, we can delete the Telemetry-side shim that refers to discover. BUG=catapult:#3612 Review-Url: https://codereview.chromium.org/2962703002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/55cfd27e1eefe8d846e221952b0544988d9a9ab9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
D telemetry/telemetry/core/discover.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eakuefner
Ned, PTAL. The Chromium side must land before this CL.
3 years, 5 months ago (2017-06-27 17:06:36 UTC) #2
nednguyen
lgtm
3 years, 5 months ago (2017-06-27 17:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962703002/1
3 years, 5 months ago (2017-07-05 19:18:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_TIMED_OUT, build has not ...
3 years, 5 months ago (2017-07-05 21:19:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962703002/1
3 years, 5 months ago (2017-07-05 21:44:59 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 21:46:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698