NetworkService: Destroy NetworkContexts on NetworkService teardown.

NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

BUG=736472
Review-Url: https://codereview.chromium.org/2962693002
Cr-Commit-Position: refs/heads/master@{#482745}
Committed: https://chromium.googlesource.com/chromium/src/+/cfbf85b0c37adf3acccead282bf5c9b794ba4009

[mmenke, 2017-06-27 15:59:09]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 15:59:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-27 16:01:39]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 16:01:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 17:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 17:22:28]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-06-27 17:54:25]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org

[mmenke, 2017-06-27 18:01:02]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 18:01:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 19:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 19:24:12]

Dry run: This issue passed the CQ dry run.

[jam, 2017-06-27 21:05:20]

lgtm

[mmenke, 2017-06-27 21:10:51]

On 2017/06/27 21:05:20, jam wrote:
> lgtm

Thanks!

[mmenke, 2017-06-27 21:10:58]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:11:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:15:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498597858399850,
"parent_rev": "958810932f8b93831d919b8915c3c916db559636", "commit_rev":
"cfbf85b0c37adf3acccead282bf5c9b794ba4009"}

[commit-bot: I haz the power, 2017-06-27 21:15:15]

Description was changed from

==========
NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

BUG=736472
==========

to

==========
NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

BUG=736472

Review-Url: https://codereview.chromium.org/2962693002
Cr-Commit-Position: refs/heads/master@{#482745}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfbf85b0c37adf3acccead282bf5...
==========

[commit-bot: I haz the power, 2017-06-27 21:15:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cfbf85b0c37adf3acccead282bf5...

[mmenke, 2017-06-27 22:18:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2960843005/ by mmenke@chromium.org.

The reason for reverting is: This conflicted with
https://codereview.chromium.org/2951813002/, which landed at about the same
time.  Will fix and reland..