Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2961773002: Compute subtyped names. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute subtyped names. This is a step to optimizing implemented classes / members feature. The idea is that we don't need to know elements to make this feature work. We just need to know whether at least one exists. So, use these subtyped names to pre-filter files, then read resolved units for special type of index (to be implemented) with resolved subtyped classes with overridden class members, then recurse. I think this would be much faster than to actually resynthesize elements. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dab293af60ebdc8aa887750d844ff90245e1b589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/referenced_names.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/referenced_names_test.dart View 2 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-27 02:06:51 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-27 13:34:36 UTC) #2
scheglov
3 years, 5 months ago (2017-06-27 16:18:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dab293af60ebdc8aa887750d844ff90245e1b589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698