Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2959713003: Remove tr.b.findFirstKeyInDictMatching. (Closed)

Created:
3 years, 5 months ago by benjhayden
Modified:
3 years, 5 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove tr.b.findFirstKeyInDictMatching. This helper function is only used twice, and is trivial to replace with either a short loop or another dictionary/Map. BUG=catapult:#3387 Review-Url: https://codereview.chromium.org/2959713003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bdff8501d71be9e9e710f3effa09a5c3a7acaa6a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -47 lines) Patch
M tracing/tracing/base/iteration_helpers.html View 1 2 2 chunks +0 lines, -22 lines 0 comments Download
M tracing/tracing/base/iteration_helpers_test.html View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M tracing/tracing/base/multi_dimensional_view_test.html View 1 1 chunk +9 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/mouse_mode_icon.html View 1 chunk +2 lines, -7 lines 0 comments Download
M tracing/tracing/ui/base/mouse_modes.html View 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
benjhayden
PTAL
3 years, 5 months ago (2017-06-27 04:36:09 UTC) #2
eakuefner
lgtm Just want to make sure you've sanity checked the viewer changes locally.
3 years, 5 months ago (2017-06-27 16:09:08 UTC) #4
benjhayden
On 2017/06/27 at 16:09:08, eakuefner wrote: > lgtm > > Just want to make sure ...
3 years, 5 months ago (2017-06-27 16:44:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959713003/20001
3 years, 5 months ago (2017-06-27 16:44:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Android%20Tryserver/builds/3975)
3 years, 5 months ago (2017-06-27 17:23:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959713003/40001
3 years, 5 months ago (2017-06-27 17:29:59 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:54:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698