Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2959573002: Add star to the rating of playstore app (Closed)

Created:
3 years, 6 months ago by weidongg
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add star to the rating of playstore app This CL add an star icon behind the rating score for apps from playstore in SearchResultTileItemView. specs: https://screenshot.googleplex.com/8j89JcgbKPn screenshot: https://screenshot.googleplex.com/0DyDJPYmKa3 BUG=734841 Review-Url: https://codereview.chromium.org/2959573002 Cr-Commit-Position: refs/heads/master@{#482831} Committed: https://chromium.googlesource.com/chromium/src/+/98cf368ffef110f3a00dabe56289cee021b72c7e

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M ui/app_list/vector_icons/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/ic_badge_rating.icon View 1 chunk +17 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/ic_badge_rating.1x.icon View 1 chunk +17 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_view.cc View 1 2 3 6 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
weidongg
3 years, 6 months ago (2017-06-24 00:55:32 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/2959573002/diff/20001/ui/app_list/views/search_result_tile_item_view.cc File ui/app_list/views/search_result_tile_item_view.cc (right): https://codereview.chromium.org/2959573002/diff/20001/ui/app_list/views/search_result_tile_item_view.cc#newcode274 ui/app_list/views/search_result_tile_item_view.cc:274: rating_star_->SetBoundsRect(rating_star_rect); Please run with a rtl lang (e.g. ...
3 years, 5 months ago (2017-06-27 14:46:03 UTC) #3
weidongg
Thanks for the review, just rebased the code. https://codereview.chromium.org/2959573002/diff/20001/ui/app_list/views/search_result_tile_item_view.cc File ui/app_list/views/search_result_tile_item_view.cc (right): https://codereview.chromium.org/2959573002/diff/20001/ui/app_list/views/search_result_tile_item_view.cc#newcode274 ui/app_list/views/search_result_tile_item_view.cc:274: rating_star_->SetBoundsRect(rating_star_rect); ...
3 years, 5 months ago (2017-06-27 17:06:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959573002/40001
3 years, 5 months ago (2017-06-27 21:06:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/369114)
3 years, 5 months ago (2017-06-27 21:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959573002/60001
3 years, 5 months ago (2017-06-28 00:59:07 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:03:13 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/98cf368ffef110f3a00dabe56289...

Powered by Google App Engine
This is Rietveld 408576698