Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2956023002: Remove tr.b.dictionaryContainsValue. (Closed)

Created:
3 years, 5 months ago by benjhayden
Modified:
3 years, 5 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove tr.b.dictionaryContainsValue. This helper function is trivial to replace with new Set(Object.values(haystack)).has(needle) BUG=catapult:#3387 Review-Url: https://codereview.chromium.org/2956023002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/78a8fc52838742fc5a325f4a8dc68472808cb4f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M tracing/tracing/base/iteration_helpers.html View 2 chunks +0 lines, -10 lines 0 comments Download
M tracing/tracing/base/iteration_helpers_test.html View 1 chunk +0 lines, -12 lines 0 comments Download
M tracing/tracing/ui/base/table.html View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 5 months ago (2017-06-27 04:44:50 UTC) #2
eakuefner
lgtm
3 years, 5 months ago (2017-06-27 16:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956023002/1
3 years, 5 months ago (2017-06-27 16:07:29 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 16:58:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698