Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: base/metrics/histogram.cc

Issue 2955893002: Keep unlogged-samples object for minidump. (Closed)
Patch Set: move the debug/alias to the end of the method Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.cc
diff --git a/base/metrics/histogram.cc b/base/metrics/histogram.cc
index b7ef10749f86c7387f553137882474497801e311..1bfcffc0804009b71b70a1e06098f40b0551e577 100644
--- a/base/metrics/histogram.cc
+++ b/base/metrics/histogram.cc
@@ -614,12 +614,14 @@ std::unique_ptr<SampleVector> Histogram::SnapshotAllSamples() const {
std::unique_ptr<SampleVector> Histogram::SnapshotUnloggedSamples() const {
// TODO(bcwhite): Remove these CHECKs once crbug/734049 is resolved.
+ HistogramSamples* unlogged = unlogged_samples_.get();
CHECK(unlogged_samples_);
CHECK(unlogged_samples_->id());
CHECK(bucket_ranges());
std::unique_ptr<SampleVector> samples(
new SampleVector(unlogged_samples_->id(), bucket_ranges()));
samples->Add(*unlogged_samples_);
+ debug::Alias(&unlogged);
return samples;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698