Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2955893002: Keep unlogged-samples object for minidump. (Closed)

Created:
3 years, 5 months ago by bcwhite
Modified:
3 years, 5 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep unlogged-samples object for minidump. BUG=734049 Review-Url: https://codereview.chromium.org/2955893002 Cr-Commit-Position: refs/heads/master@{#482661} Committed: https://chromium.googlesource.com/chromium/src/+/00537d1c4e8750ec7a64b83af947a7f7429a42ac

Patch Set 1 #

Patch Set 2 : move the debug/alias to the end of the method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/metrics/histogram.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
bcwhite
3 years, 5 months ago (2017-06-26 16:12:31 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 5 months ago (2017-06-27 17:14:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955893002/20001
3 years, 5 months ago (2017-06-27 17:14:54 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:22:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00537d1c4e8750ec7a64b83af947...

Powered by Google App Engine
This is Rietveld 408576698