Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2955063004: Fix recovery to prevent generating a parameter with no name and no type (issue 30020) (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix recovery to prevent generating a parameter with no name and no type (issue 30020) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d129b0261c3bdb332edf2472f1c1c79e9dc7ca93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +21 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-27 15:37:11 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-27 16:14:37 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-06-27 16:19:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d129b0261c3bdb332edf2472f1c1c79e9dc7ca93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698