Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2955053002: Remove tr.b.identity. (Closed)

Created:
3 years, 5 months ago by benjhayden
Modified:
3 years, 5 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove tr.b.identity. This helper function is trivial to replace with (x => x). BUG=catapult:#3387 Review-Url: https://codereview.chromium.org/2955053002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0af10945a51330428bf55fd903ea552ea190c084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -54 lines) Patch
M tracing/tracing/base/iteration_helpers.html View 4 chunks +2 lines, -8 lines 0 comments Download
M tracing/tracing/base/iteration_helpers_test.html View 1 chunk +0 lines, -16 lines 0 comments Download
M tracing/tracing/base/math/range.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/math/statistics.html View 10 chunks +9 lines, -11 lines 0 comments Download
M tracing/tracing/metrics/metric_registry.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/clock_sync_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html View 8 chunks +8 lines, -9 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/tracks/model_track.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 5 months ago (2017-06-27 05:02:40 UTC) #2
eakuefner
lgtm
3 years, 5 months ago (2017-06-27 16:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955053002/1
3 years, 5 months ago (2017-06-27 16:07:20 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 16:32:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698