Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2955043002: Remove tr.b.asArray. (Closed)

Created:
3 years, 5 months ago by benjhayden
Modified:
3 years, 5 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove tr.b.asArray. This helper function is trivial to replace with Array.from(). BUG=catapult:#3387 Review-Url: https://codereview.chromium.org/2955043002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/45d20f29a9ac09db8e197637ff975b0c9fbe01b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -99 lines) Patch
M tracing/tracing/base/iteration_helpers.html View 2 chunks +0 lines, -20 lines 0 comments Download
M tracing/tracing/base/iteration_helpers_test.html View 4 chunks +6 lines, -20 lines 0 comments Download
M tracing/tracing/base/multi_dimensional_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/base/unittest/interactive_test_runner.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/core/test_utils.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/container_memory_dump_sub_view_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/flow_classifier_test.html View 1 chunk +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_vm_regions_details_pane_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_object_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_selection.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/find_controller_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/drawing_container.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/scalar_context_controller_test.html View 7 chunks +16 lines, -16 lines 0 comments Download
M tracing/tracing/value/ui/scalar_span_test.html View 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 5 months ago (2017-06-27 04:53:26 UTC) #2
eakuefner
lgtm
3 years, 5 months ago (2017-06-27 16:06:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955043002/1
3 years, 5 months ago (2017-06-27 16:07:18 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 16:34:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698