Updates table-like objects when cells are added or removed.

Updates table-like objects when cells are added or removed.

When a table, grid or tree grid is dynamically updated through JavaScript and some cells are added or removed, we would fire a children changed event on the affected table rows, but we were not re-calculating the attributes stored in the table-like object itself, such as the list of cell IDs. This caused some hard to debug errors.
R=dmazzoni@chromium.org
BUG=736542
Review-Url: https://codereview.chromium.org/2953363002
Cr-Commit-Position: refs/heads/master@{#482792}
Committed: https://chromium.googlesource.com/chromium/src/+/24930aec1c8e42945e1a008e0924fa95750ce84a

[dmazzoni, 2017-06-26 16:55:53]

lgtm, but would like a test.

How about a DumpAccessibiliyTree test that has some
JavaScript run to modify the table a few milliseconds
after load complete, then use @WAIT-FOR for some text
that gets changed by JavaScript so that it doesn't dump
the tree until after that change happens.

Basically don't assert that the right events are fired,
just assert that the resulting accessibility tree
reflects the renumbering.

[chromium-reviews, 2017-06-27 02:50:11]

I added a test but I don't know if I can print the cell IDs stored on 
the table object to make the test even stronger.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2017-06-27 17:23:17]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 17:23:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 18:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:04:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-06-27 19:30:12]

lgtm

Cell ids in the test would be a plus but this is sufficient because the main
table's cell ids are 9 and not 12 elements as you said.

[nektarios, 2017-06-27 19:36:41]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-06-27 19:37:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:07:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:07:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-06-27 21:46:33]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-06-27 21:46:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2953363002/#ps80001
(title: "Updates table-like objects when cell IDs are added or removed.")

[commit-bot: I haz the power, 2017-06-27 21:47:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:02:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-06-27 22:17:00]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:17:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 23:32:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498601820729330,
"parent_rev": "b661c1ee56b4602565fa3e0197904ce254bf4948", "commit_rev":
"806466d81d000f8197bb1a1fbbd1755b9e20a353"}

[commit-bot: I haz the power, 2017-06-27 23:32:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498601820729330,
"parent_rev": "df11c070beef44a89a1baaa6044070be41cc33f7", "commit_rev":
"24930aec1c8e42945e1a008e0924fa95750ce84a"}

[commit-bot: I haz the power, 2017-06-27 23:32:46]

Description was changed from

==========
Updates table-like objects when cells are added or removed.

When a table, grid or tree grid is dynamically updated through JavaScript and
some cells are added or removed, we would fire a children changed event on the
affected table rows, but we were not re-calculating the attributes stored in the
table-like object itself, such as the list of cell IDs. This caused some hard to
debug errors.
R=dmazzoni@chromium.org
BUG=736542
==========

to

==========
Updates table-like objects when cells are added or removed.

When a table, grid or tree grid is dynamically updated through JavaScript and
some cells are added or removed, we would fire a children changed event on the
affected table rows, but we were not re-calculating the attributes stored in the
table-like object itself, such as the list of cell IDs. This caused some hard to
debug errors.
R=dmazzoni@chromium.org
BUG=736542

Review-Url: https://codereview.chromium.org/2953363002
Cr-Commit-Position: refs/heads/master@{#482792}
Committed:
https://chromium.googlesource.com/chromium/src/+/24930aec1c8e42945e1a008e0924...
==========

[commit-bot: I haz the power, 2017-06-27 23:32:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/24930aec1c8e42945e1a008e0924...