content/common/service_worker/service_worker_client_info.h - Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_client_info.h

Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time (Closed)

Patch Set: Address shimazu's comments #31 and fix the test failure Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_worker/service_worker_client_info.h

diff --git a/content/common/service_worker/service_worker_client_info.h b/content/common/service_worker/service_worker_client_info.h

index 93bfdf447a2c03e73233649bf53f6a58572dade6..5d789e4b560905780c0a30258d3936270ef4517b 100644

--- a/content/common/service_worker/service_worker_client_info.h

+++ b/content/common/service_worker/service_worker_client_info.h

@@ -26,6 +26,7 @@ struct ServiceWorkerClientInfo {

const GURL& url,

RequestContextFrameType frame_type,

base::TimeTicks last_focus_time,

+ base::TimeTicks create_time,

blink::WebServiceWorkerClientType client_type);

ServiceWorkerClientInfo(const ServiceWorkerClientInfo& other);

@@ -42,6 +43,7 @@ struct ServiceWorkerClientInfo {

GURL url;

RequestContextFrameType frame_type;

base::TimeTicks last_focus_time;

+ base::TimeTicks create_time;

blink::WebServiceWorkerClientType client_type;

};