Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: content/common/service_worker/service_worker_client_info.cc

Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time (Closed)
Patch Set: Address shimazu's comments #31 and fix the test failure Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker_client_info.cc
diff --git a/content/common/service_worker/service_worker_client_info.cc b/content/common/service_worker/service_worker_client_info.cc
index 1a6ba5513dcfd838db38ddab5c11263127897774..b0a2de15b66bf87a1c144c4eb8312e93c8ec2ccd 100644
--- a/content/common/service_worker/service_worker_client_info.cc
+++ b/content/common/service_worker/service_worker_client_info.cc
@@ -16,6 +16,7 @@ ServiceWorkerClientInfo::ServiceWorkerClientInfo()
GURL(),
REQUEST_CONTEXT_FRAME_TYPE_LAST,
base::TimeTicks(),
+ base::TimeTicks(),
blink::kWebServiceWorkerClientTypeLast) {}
ServiceWorkerClientInfo::ServiceWorkerClientInfo(
@@ -25,6 +26,7 @@ ServiceWorkerClientInfo::ServiceWorkerClientInfo(
const GURL& url,
RequestContextFrameType frame_type,
base::TimeTicks last_focus_time,
+ base::TimeTicks create_time,
blink::WebServiceWorkerClientType client_type)
: client_uuid(client_uuid),
page_visibility_state(page_visibility_state),
@@ -32,6 +34,7 @@ ServiceWorkerClientInfo::ServiceWorkerClientInfo(
url(url),
frame_type(frame_type),
last_focus_time(last_focus_time),
+ create_time(create_time),
client_type(client_type) {}
ServiceWorkerClientInfo::ServiceWorkerClientInfo(
« no previous file with comments | « content/common/service_worker/service_worker_client_info.h ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698