content/browser/service_worker/service_worker_version.h - Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time (Closed)

Patch Set: Address shimazu's comments #31 and fix the test failure Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 917fe64bf6a7e3eb4836136bace13309dd57bb6c..78be509688c6cad7585b0372e5b46cbad0465bbb 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -633,7 +633,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

void OnGetClientFinished(int request_id,

const ServiceWorkerClientInfo& client_info);

- void OnGetClientsFinished(int request_id, ServiceWorkerClients* clients);

+ void OnGetClientsFinished(int request_id,

+ std::unique_ptr<ServiceWorkerClients> clients);

// The timeout timer periodically calls OnTimeoutTimer, which stops the worker

// if it is excessively idle or unresponsive to ping.