content/browser/service_worker/service_worker_provider_host.cc - Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2905593002: Clients.matchAll() should return ordered clients by type/focus time/creation time (Closed)

Patch Set: Address shimazu's comments #31 and fix the test failure Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index a616574a951dc13897a7a22b5a5657e960e11cde..823e506085180f4340d40545cf9a49402af1eea9 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -147,6 +147,7 @@ ServiceWorkerProviderHost::ServiceWorkerProviderHost(

base::WeakPtr<ServiceWorkerContextCore> context,

ServiceWorkerDispatcherHost* dispatcher_host)

: client_uuid_(base::GenerateGUID()),

+ create_time_(base::TimeTicks::Now()),

render_process_id_(render_process_id),

render_thread_id_(kDocumentMainThreadId),

info_(std::move(info)),