Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2902873002: Views/Harmony Remove references to ui/views/layout/layout_constants.h (Closed)

Created:
3 years, 7 months ago by ananta
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Views/Harmony Remove references to ui/views/layout/layout_constants.h Replace references to constants in ui/views/layout/layout_constants.h with their equivalents using ChromeLayoutProvider. BUG=691897

Patch Set 1 #

Patch Set 2 : Add more files #

Patch Set 3 : Add more files #

Total comments: 1

Patch Set 4 : Fix build failures #

Patch Set 5 : Fix build failures #

Patch Set 6 : Fix patch failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -92 lines) Patch
M chrome/browser/ui/views/ime/ime_warning_bubble_view.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/importer/import_lock_dialog_view.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 29 chunks +112 lines, -64 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 2 15 chunks +46 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
ananta
https://codereview.chromium.org/2902873002/diff/40001/chrome/browser/ui/views/translate/translate_bubble_view.cc File chrome/browser/ui/views/translate/translate_bubble_view.cc (right): https://codereview.chromium.org/2902873002/diff/40001/chrome/browser/ui/views/translate/translate_bubble_view.cc#newcode617 chrome/browser/ui/views/translate/translate_bubble_view.cc:617: if (Use2016Q2UI()) { This possibly can be ripped out. ...
3 years, 7 months ago (2017-05-24 03:32:49 UTC) #2
ananta
Please ignore this patch.
3 years, 7 months ago (2017-05-24 06:31:02 UTC) #11
Peter Kasting
3 years, 7 months ago (2017-05-24 16:27:39 UTC) #12
On 2017/05/24 06:31:02, ananta wrote:
> Please ignore this patch.

Closing then.

Powered by Google App Engine
This is Rietveld 408576698