Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2902053003: Refactor LayoutText::AbsoluteQuadsForRange()

Created:
3 years, 7 months ago by yoichio
Modified:
3 years, 7 months ago
Reviewers:
kojii
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor LayoutText::AbsoluteQuadsForRange() Following code flow doesn't make sense: bool has_checked_box_in_range = !quads.IsEmpty(); if (!has_checked_box_in_range) { has_checked_box_in_range = true; quads.clear(); } Because if |quads| is empty, we don't need to clear it. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
yoichio
3 years, 7 months ago (2017-05-24 05:50:14 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698