Replace NinePieceImage.setMaskDefault with static method.

Replace NinePieceImage.setMaskDefault with static method.

For NinePieceImages that are used as masks, we currently create a
default NinePieceImage and then call setMaskDefault on it. This is
unnecessarily complicated. Instead, we could just have a static method
on NinePieceImage that creates a mask NinePieceImage. This patch adds
a static method NinePieceImage::MaskDefaults() that returns a
NinePieceImage with its members initialised to mask defaults.

BUG=628043
Review-Url: https://codereview.chromium.org/2901433002
Cr-Commit-Position: refs/heads/master@{#474177}
Committed: https://chromium.googlesource.com/chromium/src/+/43a17a2ec583e217c93c9895cfe90388b7c8ed2e

[shend, 2017-05-22 01:59:19]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 01:59:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-22 01:59:26]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-05-22 01:59:26]

Hi Bugs, PTAL

[Bugs Nash, 2017-05-22 02:56:34]

lgtm, yay for moving code to initialization lists :)

[shend, 2017-05-22 03:04:57]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-05-22 03:04:57]

Hi Alan, PTAL

[commit-bot: I haz the power, 2017-05-22 03:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 03:56:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2017-05-24 03:01:37]

lgtm

[shend, 2017-05-24 03:19:58]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 03:21:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:37:32]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 05:43:01]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:43:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:48:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495604581970750, "parent_rev":
"171284077b44d0102ffc9065331fb3b1efe3fb67", "commit_rev":
"43a17a2ec583e217c93c9895cfe90388b7c8ed2e"}

[commit-bot: I haz the power, 2017-05-24 05:49:05]

Description was changed from

==========
Replace NinePieceImage.setMaskDefault with static method.

For NinePieceImages that are used as masks, we currently create a
default NinePieceImage and then call setMaskDefault on it. This is
unnecessarily complicated. Instead, we could just have a static method
on NinePieceImage that creates a mask NinePieceImage. This patch adds
a static method NinePieceImage::MaskDefaults() that returns a
NinePieceImage with its members initialised to mask defaults.

BUG=628043
==========

to

==========
Replace NinePieceImage.setMaskDefault with static method.

For NinePieceImages that are used as masks, we currently create a
default NinePieceImage and then call setMaskDefault on it. This is
unnecessarily complicated. Instead, we could just have a static method
on NinePieceImage that creates a mask NinePieceImage. This patch adds
a static method NinePieceImage::MaskDefaults() that returns a
NinePieceImage with its members initialised to mask defaults.

BUG=628043

Review-Url: https://codereview.chromium.org/2901433002
Cr-Commit-Position: refs/heads/master@{#474177}
Committed:
https://chromium.googlesource.com/chromium/src/+/43a17a2ec583e217c93c9895cfe9...
==========

[commit-bot: I haz the power, 2017-05-24 05:49:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43a17a2ec583e217c93c9895cfe9...