media: Add experimental feature to enable Mojo CDM on desktop Chromium

media: Add experimental feature to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
pepper plugin. This CL updates the build flags such that when pepper
CDMs are enabled, we also enable hosting the CDM using mojo in an
unsandboxed utility process. By default, pepper CDM will always be
used and mojo CDM is disabled. A new base::Feature is added such that
developers and testers can enable mojo CDM for early prototyping and
testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Detailed changes in this CL:
- Updated build flags to enable mojo CDM in utility process when pepper
  CDMs are enabled.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

Note that Mojo CDM on desktop Chromium is still under development. Some
features will not work. Also, the CDM is running in an unsandboxed
utility process since we cannot load the CDM in a sandboxed utility
process yet. These will be addressed in future CLs.

BUG=403462, 725394, 561090
Review-Url: https://codereview.chromium.org/2900773004
Cr-Commit-Position: refs/heads/master@{#474186}
Committed: https://chromium.googlesource.com/chromium/src/+/846b429c5175d3637e4183bc06eb417eee09482c

[xhwang, 2017-05-22 21:35:56]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:36:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 21:39:53]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xhwang, 2017-05-22 22:54:39]

rebase only

[xhwang, 2017-05-22 22:54:48]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:55:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-22 22:56:24]

Description was changed from

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm --no-sandbox

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.

BUG=403462
==========

to

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm --no-sandbox

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462
==========

[xhwang, 2017-05-22 22:56:41]

Description was changed from

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm --no-sandbox

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462
==========

to

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462
==========

[commit-bot: I haz the power, 2017-05-22 23:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:00:46]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2017-05-22 23:33:53]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:34:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:55:43]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[xhwang, 2017-05-23 07:51:25]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 07:51:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 07:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:56:36]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[xhwang, 2017-05-23 07:57:30]

Description was changed from

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462
==========

to

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462,725394,561090
==========

[xhwang, 2017-05-23 08:02:10]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 08:02:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 08:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:07:11]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[xhwang, 2017-05-23 08:12:51]

Patchset #5 (id:80001) has been deleted

[xhwang, 2017-05-23 08:12:57]

Patchset #4 (id:60001) has been deleted

[xhwang, 2017-05-23 08:13:06]

Patchset #3 (id:40001) has been deleted

[xhwang, 2017-05-23 08:14:12]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 08:14:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-23 08:16:09]

Description was changed from

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that --no-sandbox is required since we cannot load the CDM in a
sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462,725394,561090
==========

to

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that the CDM is running in an unsandboxed utility process since we
cannot load the CDM in a sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462,725394,561090
==========

[commit-bot: I haz the power, 2017-05-23 08:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:41:13]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[xhwang, 2017-05-23 16:27:05]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 16:27:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:30:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xhwang, 2017-05-23 17:14:30]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 17:15:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-23 17:24:04]

Patchset #4 (id:120001) has been deleted

[xhwang, 2017-05-23 17:24:14]

Patchset #3 (id:100001) has been deleted

[xhwang, 2017-05-23 18:01:31]

xhwang@chromium.org changed reviewers:
+ jrummell@chromium.org

[xhwang, 2017-05-23 18:01:31]

jrummell: PTAL
ddorwin: FYI

[xhwang, 2017-05-23 18:07:59]

Description was changed from

==========
media: Add an experimental flag to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
PPAPI plugin. This CL updates the build flags such that we also support
hosting the CDM directly in Chromium, using mojo CDM.

However, Mojo CDM on desktop Chromium is still under development. So
it is disabled by default. A new base::Feature is added such that
developers and testers can enable mojo CDM for prototyping and testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Note that the CDM is running in an unsandboxed utility process since we
cannot load the CDM in a sandboxed utility process yet.

Detailed changes in this CL:
- Updated build flags to enable mojo CDM on cros/linux/mac/win. The CDM
  (run as part of MediaService) will run in the utility process.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

BUG=403462,725394,561090
==========

to

==========
media: Add experimental feature to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
pepper plugin. This CL updates the build flags such that when pepper
CDMs are enabled, we also enable hosting the CDM using mojo in an
unsandboxed utility process. By default, pepper CDM will always be
used and mojo CDM is disabled. A new base::Feature is added such that
developers and testers can enable mojo CDM for early prototyping and
testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Detailed changes in this CL:
- Updated build flags to enable mojo CDM in utility process when pepper
  CDMs are enabled.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

Note that Mojo CDM on desktop Chromium is still under development. Some
features will not work. Also, the CDM is running in an unsandboxed
utility process since we cannot load the CDM in a sandboxed utility
process yet. These will be addressed in future CLs.

BUG=403462,725394,561090
==========

[commit-bot: I haz the power, 2017-05-23 18:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:50:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jrummell, 2017-05-23 22:23:28]

lgtm

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
content/renderer/render_frame_impl.cc:6795: #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
Is it possible for cdm_factory_ to get set twice? Should this be first above,
then #elif ENABLE_PEPPER_CDMS?

https://codereview.chromium.org/2900773004/diff/140001/media/cdm/cdm_adapter_...
File media/cdm/cdm_adapter_factory.cc (right):

https://codereview.chromium.org/2900773004/diff/140001/media/cdm/cdm_adapter_...
media/cdm/cdm_adapter_factory.cc:59:
GetPlatformSpecificDirectory(kWidevineCdmBaseDirectory));
Can you use DIR_COMPONENT_WIDEVINE_CDM to get the Widevine directory? Doesn't
look like there is anything that uses the library name, but at least simplify
getting the directory.

[xhwang, 2017-05-23 22:31:12]

Thanks for the review!

Comments-to-comments only.

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
content/renderer/render_frame_impl.cc:6795: #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
On 2017/05/23 22:23:28, jrummell wrote:
> Is it possible for cdm_factory_ to get set twice? Should this be first above,
> then #elif ENABLE_PEPPER_CDMS?

The RemotingCdmFactory actually wraps the cdm_factory_ set above, so this has to
be after the above block.

https://codereview.chromium.org/2900773004/diff/140001/media/cdm/cdm_adapter_...
File media/cdm/cdm_adapter_factory.cc (right):

https://codereview.chromium.org/2900773004/diff/140001/media/cdm/cdm_adapter_...
media/cdm/cdm_adapter_factory.cc:59:
GetPlatformSpecificDirectory(kWidevineCdmBaseDirectory));
On 2017/05/23 22:23:28, jrummell wrote:
> Can you use DIR_COMPONENT_WIDEVINE_CDM to get the Widevine directory? Doesn't
> look like there is anything that uses the library name, but at least simplify
> getting the directory.

DIR_COMPONENT_WIDEVINE_CDM points to the component updated CDM, which isn't
always available. Instead, we always have the bundled CDM, which is in the
PlatformSpecificDirectory, and is what we'll use in the current mojo CDM path.
In the future, we'll update CDM registration and pass the CDM path from the
browser so that we don't need this hack here.

[xhwang, 2017-05-23 22:32:14]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[xhwang, 2017-05-23 22:32:52]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2017-05-23 22:32:52]

jam: Please content/ OWNERS review.
rockot: FYI

[commit-bot: I haz the power, 2017-05-23 22:34:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-05-24 00:36:33]

lgtm

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2900773004/diff/140001/content/renderer/rende...
content/renderer/render_frame_impl.cc:6788: else
nit: brace brackets per style guide

[xhwang, 2017-05-24 00:51:09]

comments addressed

[xhwang, 2017-05-24 00:51:15]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 00:51:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-24 00:52:00]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2017-05-24 00:52:00]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2017-05-24 00:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2900773004/#ps160001
(title: "comments addressed")

[commit-bot: I haz the power, 2017-05-24 00:52:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:24:58]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xhwang, 2017-05-24 04:35:06]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 04:36:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-05-24 05:51:17]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2017-05-24 05:51:17]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2017-05-24 05:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2900773004/#ps180001
(title: "drop utility_process_host_impl.cc change")

[commit-bot: I haz the power, 2017-05-24 05:51:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 06:45:16]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495605077943790,
"parent_rev": "d10a8c41ef88566b25aff3f763ac7ec605bac4ea", "commit_rev":
"846b429c5175d3637e4183bc06eb417eee09482c"}

[commit-bot: I haz the power, 2017-05-24 06:45:35]

Description was changed from

==========
media: Add experimental feature to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
pepper plugin. This CL updates the build flags such that when pepper
CDMs are enabled, we also enable hosting the CDM using mojo in an
unsandboxed utility process. By default, pepper CDM will always be
used and mojo CDM is disabled. A new base::Feature is added such that
developers and testers can enable mojo CDM for early prototyping and
testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Detailed changes in this CL:
- Updated build flags to enable mojo CDM in utility process when pepper
  CDMs are enabled.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

Note that Mojo CDM on desktop Chromium is still under development. Some
features will not work. Also, the CDM is running in an unsandboxed
utility process since we cannot load the CDM in a sandboxed utility
process yet. These will be addressed in future CLs.

BUG=403462,725394,561090
==========

to

==========
media: Add experimental feature to enable Mojo CDM on desktop Chromium

Currently in Chromium, the CDM is hosted by the CDM adapter which is a
pepper plugin. This CL updates the build flags such that when pepper
CDMs are enabled, we also enable hosting the CDM using mojo in an
unsandboxed utility process. By default, pepper CDM will always be
used and mojo CDM is disabled. A new base::Feature is added such that
developers and testers can enable mojo CDM for early prototyping and
testing.

To enable mojo CDM, please add the following command line options:

--enable-features=MojoCdm

Detailed changes in this CL:
- Updated build flags to enable mojo CDM in utility process when pepper
  CDMs are enabled.
- Add a base::Feature media::kMojoCdm to enable mojo CDM at run time.
- Add CdmAdapterFactory to create CdmAdapter, which hosts the CDM
  binary.
- Register MediaService in the utility process to create
  CdmAdapterFactory when requested.
- Also copy base::Feature flags on command line for utility process.

Note that Mojo CDM on desktop Chromium is still under development. Some
features will not work. Also, the CDM is running in an unsandboxed
utility process since we cannot load the CDM in a sandboxed utility
process yet. These will be addressed in future CLs.

BUG=403462,725394,561090

Review-Url: https://codereview.chromium.org/2900773004
Cr-Commit-Position: refs/heads/master@{#474186}
Committed:
https://chromium.googlesource.com/chromium/src/+/846b429c5175d3637e4183bc06eb...
==========

[commit-bot: I haz the power, 2017-05-24 06:45:37]

Committed patchset #5 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/846b429c5175d3637e4183bc06eb...

[vitaliii, 2017-05-24 07:53:04]

A revert of this CL (patchset #5 id:180001) has been created in
https://codereview.chromium.org/2902943002/ by vitaliii@chromium.org.

The reason for reverting is: This CL seems to break |generate_build_files| step
on chromium.chrome/Google Chrome Win..

[vitaliii, 2017-05-24 08:09:58]

On 2017/05/24 07:53:04, vitaliii wrote:
> A revert of this CL (patchset #5 id:180001) has been created in
> https://codereview.chromium.org/2902943002/ by mailto:vitaliii@chromium.org.
> 
> The reason for reverting is: This CL seems to break |generate_build_files|
step
> on chromium.chrome/Google Chrome Win..

After the revert, |generate_build_files| step is green again. Please see
crbug.com/725808 for details.