Code cleanup for Translate Compact Infobar.

Code cleanup for Translate Compact Infobar.
1. Move shouldAutoNeverTranslate checks to native code in order to simplify front-end logic.
2. Remove declined logging on Java side, which is duplicate in native.
3. Remove unnecessary "Cancel" action .

BUG=703887
Review-Url: https://codereview.chromium.org/2899893004
Cr-Commit-Position: refs/heads/master@{#474178}
Committed: https://chromium.googlesource.com/chromium/src/+/ae952008457a2f703d91e24b301efb59718fce87

[Leo, 2017-05-23 07:52:02]

googleo@chromium.org changed reviewers:
+ martiw@chromium.org, mdjones@chromium.org

[Leo, 2017-05-23 07:52:02]

I did some code clean up and fix some logging bugs.

PTAL

[Marti Wong, 2017-05-23 08:23:32]

thx Leo~!

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/translate_compact_infobar.cc (right):

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/translate_compact_infobar.cc:152: // Don't
trigger if it's off the recored or already blocked.
typo: record

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/translate_compact_infobar.cc:179: return
action_flags_ == FLAG_NONE;
If user clicks on CLOSE after a auto translate (without menu expanded), is the
action_flags == FLAG_NONE?

So translate_ui_delegate#TranslationDeclined() (which will increment
translationDeniedCount) is called when
TranslateInfoBarDelegate::InfoBarDismissed() and IsDeclinedByUser is TRUE?

It seems quite tricky may be we should add comment here to explain this
scenario.

[Leo, 2017-05-23 13:17:38]

The CQ bit was checked by googleo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 13:17:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 14:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 14:06:56]

Dry run: This issue passed the CQ dry run.

[Leo, 2017-05-23 14:33:01]

Thanks for the review, Marti.

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
File chrome/browser/ui/android/infobars/translate_compact_infobar.cc (right):

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/translate_compact_infobar.cc:152: // Don't
trigger if it's off the recored or already blocked.
On 2017/05/23 08:23:32, Marti Wong wrote:
> typo: record

Thanks for the catch.

https://codereview.chromium.org/2899893004/diff/20001/chrome/browser/ui/andro...
chrome/browser/ui/android/infobars/translate_compact_infobar.cc:179: return
action_flags_ == FLAG_NONE;
On 2017/05/23 08:23:32, Marti Wong wrote:
> If user clicks on CLOSE after a auto translate (without menu expanded), is the
> action_flags == FLAG_NONE?
> 
> So translate_ui_delegate#TranslationDeclined() (which will increment
> translationDeniedCount) is called when
> TranslateInfoBarDelegate::InfoBarDismissed() and IsDeclinedByUser is TRUE?
> 
> It seems quite tricky may be we should add comment here to explain this
> scenario.

Added more explanation in where it's defined.

[mdjones, 2017-05-24 00:07:59]

lgtm % fix commit message:

"1. Text..."
"2. More text..."

One space between description/body and body/bug number.

[Leo, 2017-05-24 01:01:47]

Description was changed from

==========
Code cleanup for Compact Infobar.
1,Move some checks to native to simplify logic.
2,Remove declined log which is duplicate in native.


BUG=703887
==========

to

==========
Code cleanup for Translate Compact Infobar.
1. Move shouldAutoNeverTranslate checks to native code in order to simplify
front-end logic.
2. Remove declined logging on Java side, which is duplicate in native.
3. Remove unnecessary "Cancel" action .

BUG=703887
==========

[Leo, 2017-05-24 04:13:42]

The CQ bit was checked by googleo@chromium.org

[Leo, 2017-05-24 04:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2899893004/#ps60001
(title: "Merge branch 'master' into code-cleanup-5")

[commit-bot: I haz the power, 2017-05-24 04:14:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:55:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495599222897960,
"parent_rev": "43a17a2ec583e217c93c9895cfe90388b7c8ed2e", "commit_rev":
"ae952008457a2f703d91e24b301efb59718fce87"}

[commit-bot: I haz the power, 2017-05-24 05:55:28]

Description was changed from

==========
Code cleanup for Translate Compact Infobar.
1. Move shouldAutoNeverTranslate checks to native code in order to simplify
front-end logic.
2. Remove declined logging on Java side, which is duplicate in native.
3. Remove unnecessary "Cancel" action .

BUG=703887
==========

to

==========
Code cleanup for Translate Compact Infobar.
1. Move shouldAutoNeverTranslate checks to native code in order to simplify
front-end logic.
2. Remove declined logging on Java side, which is duplicate in native.
3. Remove unnecessary "Cancel" action .

BUG=703887

Review-Url: https://codereview.chromium.org/2899893004
Cr-Commit-Position: refs/heads/master@{#474178}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae952008457a2f703d91e24b301e...
==========

[commit-bot: I haz the power, 2017-05-24 05:55:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ae952008457a2f703d91e24b301e...