components/ntp_tiles/icon_cacher_impl.cc - Issue 2896803002: [LargeIconService] Make check_seen param optional for fetching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/icon_cacher_impl.cc

Issue 2896803002: [LargeIconService] Make check_seen param optional for fetching (Closed)

Patch Set: Comments on unit-test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/icon_cacher_impl.cc

diff --git a/components/ntp_tiles/icon_cacher_impl.cc b/components/ntp_tiles/icon_cacher_impl.cc

index 4c900c52354af2b7114a8449a935d9ce3a38125b..015685fac368b51ae3e2588f7cbf5aa3987eeeee 100644

--- a/components/ntp_tiles/icon_cacher_impl.cc

+++ b/components/ntp_tiles/icon_cacher_impl.cc

@@ -219,6 +219,7 @@ void IconCacherImpl::OnGetLargeIconOrFallbackStyleFinished(

large_icon_service_

->GetLargeIconOrFallbackStyleFromGoogleServerSkippingLocalCache(

page_url, kTileIconMinSizePx, kTileIconDesiredSizePx,

+ /*may_page_url_be_private=*/true,

base::Bind(&IconCacherImpl::OnMostLikelyFaviconDownloaded,

weak_ptr_factory_.GetWeakPtr(), page_url));

}

« no previous file with comments | « components/ntp_snippets/content_suggestions_service.cc ('k') | no next file » | no next file with comments »