Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2896803002: [LargeIconService] Make check_seen param optional for fetching (Closed)
Patch Set: Comments on unit-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/large_icon_service_unittest.cc ('k') | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/content_suggestions_service.cc
diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc
index 9187566adbe7fea3053ccd77fd1b3633104bcbfe..36a6167b32106b98de33c09d89e37de38b4e7130 100644
--- a/components/ntp_snippets/content_suggestions_service.cc
+++ b/components/ntp_snippets/content_suggestions_service.cc
@@ -245,9 +245,13 @@ void ContentSuggestionsService::OnGetFaviconFromCacheFinished(
}
// Try to fetch the favicon from a Google favicon server.
+ // TODO(jkrcal): Currently used only for Articles for you which have public
+ // URLs. Let the provider decide whether |publisher_url| may be private or
+ // not.
large_icon_service_
->GetLargeIconOrFallbackStyleFromGoogleServerSkippingLocalCache(
publisher_url, minimum_size_in_pixel, desired_size_in_pixel,
+ /*may_page_url_be_private=*/false,
base::Bind(
&ContentSuggestionsService::OnGetFaviconFromGoogleServerFinished,
base::Unretained(this), publisher_url, minimum_size_in_pixel,
« no previous file with comments | « components/favicon/core/large_icon_service_unittest.cc ('k') | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698