Make Hands-Off Zero-Touch Enrollment compatibile with tests

Make Hands-Off Zero-Touch Enrollment compatibile with tests

Specifically, the automatic nature of Hands-Off Enrollment leads to
the DUT performing an update check after reboot which interferes
with autoupdate_EndToEndTest. This CL fixes that issue.
It does so by instructing the UpdateScreen to skip checking for updates
if both of the following conditions hold:
1. The previous update check initiated by the UpdateScreen did not result
in an update.
2. This previous update check occurred during the last hour.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2894783003
Cr-Commit-Position: refs/heads/master@{#473388}
Committed: https://chromium.googlesource.com/chromium/src/+/f097331c78cf162157bc2e62db0b2dd5fba85c83

[kumarniranjan, 2017-05-19 17:45:08]

kumarniranjan@google.com changed reviewers:
+ alemate@chromium.org, xiyuan@chromium.org

[kumarniranjan, 2017-05-19 17:45:09]

There were memory leaks in the previous CL. I believe I have fixed them, but is
there a way for me to run the memory test again to verify? Is choosing trybots
the right way to do this?

[xiyuan, 2017-05-19 17:48:10]

For relanding, it would be nice to update original CL first then upload another
one for fix.

lgtm after fixing my comment

https://codereview.chromium.org/2894783003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/update_screen_unittest.cc (right):

https://codereview.chromium.org/2894783003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/update_screen_unittest.cc:88: //
fake_controller_ = new pairing_chromeos::FakeHostPairingController("");
Remove if it is not needed.

[kumarniranjan, 2017-05-19 18:03:02]

https://codereview.chromium.org/2894783003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/update_screen_unittest.cc (right):

https://codereview.chromium.org/2894783003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/update_screen_unittest.cc:88: //
fake_controller_ = new pairing_chromeos::FakeHostPairingController("");
On 2017/05/19 17:48:09, xiyuan wrote:
> Remove if it is not needed.

Done.

[kumarniranjan, 2017-05-19 19:31:11]

The CQ bit was checked by kumarniranjan@google.com

[kumarniranjan, 2017-05-19 19:31:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2894783003/#ps20001
(title: "Make Hands-Off Zero-Touch Enrollment compatibile with tests")

[commit-bot: I haz the power, 2017-05-19 19:32:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:45:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Alekseev, 2017-05-19 22:49:40]

lgtm

[kumarniranjan, 2017-05-19 23:20:02]

The CQ bit was checked by kumarniranjan@google.com

[commit-bot: I haz the power, 2017-05-19 23:20:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 00:00:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495236002515130,
"parent_rev": "40c99bcdd1a0c0bcd3dbcfd2c49733621eb40614", "commit_rev":
"f097331c78cf162157bc2e62db0b2dd5fba85c83"}

[commit-bot: I haz the power, 2017-05-20 00:00:50]

Description was changed from

==========
Make Hands-Off Zero-Touch Enrollment compatibile with tests

Specifically, the automatic nature of Hands-Off Enrollment leads to
the DUT performing an update check after reboot which interferes
with autoupdate_EndToEndTest. This CL fixes that issue.
It does so by instructing the UpdateScreen to skip checking for updates
if both of the following conditions hold:
1. The previous update check initiated by the UpdateScreen did not result
in an update.
2. This previous update check occurred during the last hour.

BUG=chromium:710716
TEST=unit test
==========

to

==========
Make Hands-Off Zero-Touch Enrollment compatibile with tests

Specifically, the automatic nature of Hands-Off Enrollment leads to
the DUT performing an update check after reboot which interferes
with autoupdate_EndToEndTest. This CL fixes that issue.
It does so by instructing the UpdateScreen to skip checking for updates
if both of the following conditions hold:
1. The previous update check initiated by the UpdateScreen did not result
in an update.
2. This previous update check occurred during the last hour.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2894783003
Cr-Commit-Position: refs/heads/master@{#473388}
Committed:
https://chromium.googlesource.com/chromium/src/+/f097331c78cf162157bc2e62db0b...
==========

[commit-bot: I haz the power, 2017-05-20 00:00:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f097331c78cf162157bc2e62db0b...

[joth, 2017-06-06 17:27:40]

On 2017/05/20 00:00:51, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/f097331c78cf162157bc2e62db0b...

As this CL didn't actually address it's intended goal, should it be reverted? OR
is the feature implemented desirable in its own right?

[kumarniranjan, 2017-06-06 17:33:43]

On 2017/06/06 17:27:40, joth wrote:
> On 2017/05/20 00:00:51, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/f097331c78cf162157bc2e62db0b...
> 
> As this CL didn't actually address it's intended goal, should it be reverted?
OR
> is the feature implemented desirable in its own right?

It should probably be reverted. I was just planning to wait until we got
autoupdate_EndToEndTest to pass on Kiosk mode by some other means before
reverting. But if you think it should be reverted now, that should be okay as
well.

If we don't consider the autoupdate test, this feature is undesirable (from my
point of view) because it opens a one-hour window where the device could be
potentially unable to receive a critical update.

[kumarniranjan, 2017-06-21 20:30:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2945203003/ by kumarniranjan@google.com.

The reason for reverting is: This CL did not fix the failing test. Furthermore,
it creates a security vulnerability by introducing a one-hour window where the
device will not be able to receive critical updates..