Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2893313004: Remove unused AnimatableValue types (Closed)

Created:
3 years, 7 months ago by alancutter (OOO until 2018)
Modified:
3 years, 7 months ago
Reviewers:
Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused AnimatableValue types After replacing AnimatableValues with ComputedStyle references in https://codereview.chromium.org/2895283004 we no longer need AnimatableValues outside of composited properties. This patch removes all the unused AnimatableValue code. BUG=725385 Review-Url: https://codereview.chromium.org/2893313004 Cr-Commit-Position: refs/heads/master@{#474595} Committed: https://chromium.googlesource.com/chromium/src/+/a0793c35f0db302a2a619f69670149b60a568e55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2619 lines) Patch
M third_party/WebKit/Source/core/animation/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectStackTest.cpp View 9 chunks +14 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableColor.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableColor.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableDouble.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableDouble.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleAndBool.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleAndBool.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.cpp View 2 chunks +4 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableFontVariationSettings.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableFontVariationSettings.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableImage.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLength.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatablePath.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatablePath.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableShapeValue.h View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableShapeValue.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableTransform.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableTransform.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.h View 3 chunks +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.h View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 3 chunks +6 lines, -601 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
alancutter (OOO until 2018)
3 years, 7 months ago (2017-05-23 07:00:04 UTC) #5
Eric Willigers
lgtm
3 years, 7 months ago (2017-05-24 05:47:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893313004/1
3 years, 7 months ago (2017-05-25 05:18:00 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 07:06:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0793c35f0db302a2a619f696701...

Powered by Google App Engine
This is Rietveld 408576698