Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2891423002: Disable NTP URL bar while in VR on Android.

Can't Edit
Can't Publish+Mail
Start Review
4 days, 12 hours ago by mthiesse
12 hours, 59 minutes ago
Target Ref:


Disable NTP URL bar while in VR on Android. Unfortunately we don't support keyboard or microphone input while in VR just yet, so we need to disable them to prevent the 2D popups from obscuring VR content. BUG=724551

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : javadoc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ View 1 2 4 chunks +19 lines, -1 line 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/ View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/ View 1 6 chunks +23 lines, -9 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).


Total messages: 6 (3 generated)
ymalik, asimjour: Please review VrShellImpl changes. tedchoc: Please review omnibox/ and ntp/ changes.
4 days, 12 hours ago (2017-05-19 17:54:03 UTC) #3
Ted C
+bauerb for ntp thoughts File chrome/android/java/src/org/chromium/chrome/browser/ntp/ (right): chrome/android/java/src/org/chromium/chrome/browser/ntp/ mSearchProviderHasLogo = TemplateUrlService.getInstance().isDefaultSearchEngineGoogle(); Is it ...
15 hours, 17 minutes ago (2017-05-23 14:37:46 UTC) #5
14 hours, 5 minutes ago (2017-05-23 15:50:24 UTC) #6
Amir or Yash, feel free to pick this CL up from me while I'm out this week.
Otherwise I'll get back to this on Monday.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06