[WebView] Merge AwMetricsServiceClient and move few files to new place

[WebView] Merge AwMetricsServiceClient and move few files to new place

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG=716604
Review-Url: https://codereview.chromium.org/2886283005
Cr-Commit-Position: refs/heads/master@{#473299}
Committed: https://chromium.googlesource.com/chromium/src/+/82bd374dd151cbcd4ca02ad091a48822050e507c

[Shimi Zhang, 2017-05-18 23:50:31]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 23:51:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shimi Zhang, 2017-05-19 00:38:04]

ctzsm@chromium.org changed reviewers:
+ boliu@chromium.org

[Shimi Zhang, 2017-05-19 00:38:04]

Bo, PTAL, thanks!

[boliu, 2017-05-19 02:34:34]

also, write a better first line description

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
File android_webview/common/aw_resource.cc (right):

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
android_webview/common/aw_resource.cc:5: #include
"android_webview/common/aw_resource.h"
common generally means used by both browser and renderer, I don't think renderer
needs this?

[commit-bot: I haz the power, 2017-05-19 03:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:51:48]

Dry run: This issue passed the CQ dry run.

[Shimi Zhang, 2017-05-19 16:53:08]

Description was changed from

==========
[WebView] Remove more redundant classes

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG=716604
==========

to

==========
[WebView] Merge AwMetricsServiceClient and move few files to new place

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG=716604
==========

[Shimi Zhang, 2017-05-19 17:12:11]

Description updated, PTAL, @_@..

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
File android_webview/common/aw_resource.cc (right):

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
android_webview/common/aw_resource.cc:5: #include
"android_webview/common/aw_resource.h"
On 2017/05/19 02:34:33, boliu wrote:
> common generally means used by both browser and renderer, I don't think
renderer
> needs this?

I think it was used by renderer,
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...
but got removed afterwards, the #include is not necessary.

Other than that, it used in common/
https://cs.chromium.org/chromium/src/android_webview/common/aw_content_client...

I think we should remove that #include in aw_content_renderer_client.cc but
still keep this in common/, WDYT?

[Shimi Zhang, 2017-05-19 17:18:55]

The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 17:19:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[paulmiller, 2017-05-19 17:27:06]

paulmiller@chromium.org changed reviewers:
+ paulmiller@chromium.org

[paulmiller, 2017-05-19 17:27:06]

https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_metrics_service_client.h (right):

https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_metrics_service_client.h:12: #include
"android_webview/browser/aw_metrics_service_client.h"
Recursion! :)

[boliu, 2017-05-19 17:37:21]

lgtm % recursive include

surprised there are no DEPS rules preventing renderer from including things from
browser...

https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_metrics_service_client.h (right):

https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_metrics_service_client.h:12: #include
"android_webview/browser/aw_metrics_service_client.h"
On 2017/05/19 17:27:06, paulmiller wrote:
> Recursion! :)

oh yeah, fix that too

maybe double check if previous refactors also left similar includes..

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
File android_webview/common/aw_resource.cc (right):

https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
android_webview/common/aw_resource.cc:5: #include
"android_webview/common/aw_resource.h"
On 2017/05/19 17:12:11, Shimi Zhang wrote:
> On 2017/05/19 02:34:33, boliu wrote:
> > common generally means used by both browser and renderer, I don't think
> renderer
> > needs this?
> 
> I think it was used by renderer,
>
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...
> but got removed afterwards, the #include is not necessary.
> 
> Other than that, it used in common/
>
https://cs.chromium.org/chromium/src/android_webview/common/aw_content_client...
> 
> I think we should remove that #include in aw_content_renderer_client.cc but
> still keep this in common/, WDYT?

oh it's from common, ok, yeah, makes sense

[Shimi Zhang, 2017-05-19 17:47:03]

On 2017/05/19 17:37:21, boliu wrote:
> lgtm % recursive include
> 
> surprised there are no DEPS rules preventing renderer from including things
from
> browser...

> 
>
https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
> File android_webview/browser/aw_metrics_service_client.h (right):
> 
>
https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_...
> android_webview/browser/aw_metrics_service_client.h:12: #include
> "android_webview/browser/aw_metrics_service_client.h"
> On 2017/05/19 17:27:06, paulmiller wrote:
> > Recursion! :)
> 
> oh yeah, fix that too

Oops, thanks Paul, nice catch! (and thanks to the header guard, it compiles..but
harder to catch..)
> 
> maybe double check if previous refactors also left similar includes..
> 
>
https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
> File android_webview/common/aw_resource.cc (right):
> 
>
https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_r...
> android_webview/common/aw_resource.cc:5: #include
> "android_webview/common/aw_resource.h"
> On 2017/05/19 17:12:11, Shimi Zhang wrote:
> > On 2017/05/19 02:34:33, boliu wrote:
> > > common generally means used by both browser and renderer, I don't think
> > renderer
> > > needs this?
> > 
> > I think it was used by renderer,
> >
>
https://cs.chromium.org/chromium/src/android_webview/renderer/aw_content_rend...
> > but got removed afterwards, the #include is not necessary.
> > 
> > Other than that, it used in common/
> >
>
https://cs.chromium.org/chromium/src/android_webview/common/aw_content_client...
> > 
> > I think we should remove that #include in aw_content_renderer_client.cc but
> > still keep this in common/, WDYT?
> 
> oh it's from common, ok, yeah, makes sense

Yeah, we do have that rule, the include is from common.

[boliu, 2017-05-19 17:48:11]

On 2017/05/19 17:47:03, Shimi Zhang wrote:
> Yeah, we do have that rule, the include is from common.

Oh, we should also have rules that common cannot include from browser or
renderer..

[Shimi Zhang, 2017-05-19 17:52:17]

The CQ bit was checked by ctzsm@chromium.org

[Shimi Zhang, 2017-05-19 17:52:17]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2886283005/#ps40001
(title: "remove recursive include")

[paulmiller, 2017-05-19 17:52:53]

AwMetricsServiceClient lgtm

[commit-bot: I haz the power, 2017-05-19 17:53:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:36:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495216337508110,
"parent_rev": "af4727a9a29c33197e12a7284b9ecad63422b081", "commit_rev":
"82bd374dd151cbcd4ca02ad091a48822050e507c"}

[commit-bot: I haz the power, 2017-05-19 20:36:18]

Description was changed from

==========
[WebView] Merge AwMetricsServiceClient and move few files to new place

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG=716604
==========

to

==========
[WebView] Merge AwMetricsServiceClient and move few files to new place

This CL:

1) Move files around to let them make more sense.
browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc
browser/aw_resource.cc -> common/aw_resource.cc

2) Removed aw_metrics_service_client.{h,cc} and
use aw_metrics_service_client_impl.{h,cc} to replace them.

Hitting the same banned function usage:
Use base/task_scheduler/post_task.h instead of the blocking pool.

Hence requires no presubmit check.

NOPRESUBMIT=true
BUG=716604

Review-Url: https://codereview.chromium.org/2886283005
Cr-Commit-Position: refs/heads/master@{#473299}
Committed:
https://chromium.googlesource.com/chromium/src/+/82bd374dd151cbcd4ca02ad091a4...
==========

[commit-bot: I haz the power, 2017-05-19 20:36:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/82bd374dd151cbcd4ca02ad091a4...