Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2886283005: [WebView] Merge AwMetricsServiceClient and move few files to new place (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by Shimi Zhang
Modified:
1 month, 1 week ago
Reviewers:
paulmiller, boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org, sgurun
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Merge AwMetricsServiceClient and move few files to new place This CL: 1) Move files around to let them make more sense. browser/net_init_native_callback.cc -> browser/net/init_native_callback.cc browser/aw_resource.cc -> common/aw_resource.cc 2) Removed aw_metrics_service_client.{h,cc} and use aw_metrics_service_client_impl.{h,cc} to replace them. Hitting the same banned function usage: Use base/task_scheduler/post_task.h instead of the blocking pool. Hence requires no presubmit check. NOPRESUBMIT=true BUG=716604 Review-Url: https://codereview.chromium.org/2886283005 Cr-Commit-Position: refs/heads/master@{#473299} Committed: https://chromium.googlesource.com/chromium/src/+/82bd374dd151cbcd4ca02ad091a48822050e507c

Patch Set 1 #

Total comments: 5

Patch Set 2 : remove unnecessary #include #

Patch Set 3 : remove recursive include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -389 lines) Patch
M android_webview/BUILD.gn View 5 chunks +2 lines, -4 lines 0 comments Download
M android_webview/browser/android_webview_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_metrics_service_client.h View 1 2 2 chunks +61 lines, -6 lines 0 comments Download
M android_webview/browser/aw_metrics_service_client.cc View 1 chunk +231 lines, -2 lines 0 comments Download
D android_webview/browser/aw_metrics_service_client_impl.h View 1 chunk +0 lines, -83 lines 0 comments Download
D android_webview/browser/aw_metrics_service_client_impl.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D android_webview/browser/aw_resource.cc View 1 chunk +0 lines, -28 lines 0 comments Download
A + android_webview/browser/net/init_native_callback.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D android_webview/browser/net_init_native_callback.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A + android_webview/common/aw_resource.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 23 (13 generated)
Shimi Zhang
Bo, PTAL, thanks!
1 month, 1 week ago (2017-05-19 00:38:04 UTC) #4
boliu
also, write a better first line description https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_resource.cc File android_webview/common/aw_resource.cc (right): https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_resource.cc#newcode5 android_webview/common/aw_resource.cc:5: #include "android_webview/common/aw_resource.h" ...
1 month, 1 week ago (2017-05-19 02:34:34 UTC) #5
Shimi Zhang
Description updated, PTAL, @_@.. https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_resource.cc File android_webview/common/aw_resource.cc (right): https://codereview.chromium.org/2886283005/diff/1/android_webview/common/aw_resource.cc#newcode5 android_webview/common/aw_resource.cc:5: #include "android_webview/common/aw_resource.h" On 2017/05/19 02:34:33, ...
1 month, 1 week ago (2017-05-19 17:12:11 UTC) #9
paulmiller
https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_metrics_service_client.h File android_webview/browser/aw_metrics_service_client.h (right): https://codereview.chromium.org/2886283005/diff/1/android_webview/browser/aw_metrics_service_client.h#newcode12 android_webview/browser/aw_metrics_service_client.h:12: #include "android_webview/browser/aw_metrics_service_client.h" Recursion! :)
1 month, 1 week ago (2017-05-19 17:27:06 UTC) #13
boliu
lgtm % recursive include surprised there are no DEPS rules preventing renderer from including things ...
1 month, 1 week ago (2017-05-19 17:37:21 UTC) #14
Shimi Zhang
On 2017/05/19 17:37:21, boliu wrote: > lgtm % recursive include > > surprised there are ...
1 month, 1 week ago (2017-05-19 17:47:03 UTC) #15
boliu
On 2017/05/19 17:47:03, Shimi Zhang wrote: > Yeah, we do have that rule, the include ...
1 month, 1 week ago (2017-05-19 17:48:11 UTC) #16
paulmiller
AwMetricsServiceClient lgtm
1 month, 1 week ago (2017-05-19 17:52:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886283005/40001
1 month, 1 week ago (2017-05-19 17:53:12 UTC) #20
commit-bot: I haz the power
1 month, 1 week ago (2017-05-19 20:36:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/82bd374dd151cbcd4ca02ad091a4...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318