Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2868003002: CSSPaint: Move layout tests in csspaint/ to http/tests/csspaint/ (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
ikilpatrick, style-dev, Justin Novosad
CC:
chromium-reviews, blink-reviews, falken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CSSPaint: Move layout tests in csspaint/ to http/tests/csspaint/ After ES6 modules loading for PaintWorklet (issue 627945) is introduced, layout tests for PaintWorklet are no longer able to run on non-http environment because ES6 modules does not support "file://" url (See https://crbug.com/594639#c86). This CL moves layout tests in csspaint/ to http/tests/csspaint/, and copies resources/run-after-layout-and-paint.js into http/tests/resources/. BUG=719857 Review-Url: https://codereview.chromium.org/2868003002 Cr-Commit-Position: refs/heads/master@{#474174} Committed: https://chromium.googlesource.com/chromium/src/+/a71bdb09d0b4e789a045820895ab3535bffddabf

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove expectation files for invalidation-*-image.html #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -2408 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 2 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-alpha.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-alpha-expected.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-multiple.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-multiple-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-tiled.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/background-image-tiled-expected.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-background-image.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-background-image-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-background-image-tiled.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-background-image-tiled-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-border-image.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/geometry-border-image-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-constructor-error.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-constructor-error-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-paint-error.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-paint-error-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-pending-script.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalid-image-pending-script-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-background-image.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-background-image-expected.txt View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-border-image.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-border-image-expected.txt View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-content-image.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/invalidation-content-image-expected.txt View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/overdraw.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/overdraw-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint-arguments.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint-arguments-expected.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint-function-arguments.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint-function-arguments-expected.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-composite.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-composite-expected.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-gradient.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-gradient-expected.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-image.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-image-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-paths.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-paths-expected.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-rects.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-rects-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-shadows.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-shadows-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-transform.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-transform-expected.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-zoom.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-zoom-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/paint2d-zoom-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/parse-input-arguments.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/parse-input-arguments-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/registerPaint.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/registerPaint-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/registered-properties-in-custom-paint.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/registered-properties-in-custom-paint-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/generate-paint-style-logging.js View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/html5.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/paint-logging-green.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/test-runner-geometry-logging.js View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/test-runner-invalidation-logging.js View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-helper.js View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-worklet.js View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-background-image.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-background-image-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-before-pseudo.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-before-pseudo-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-first-letter-pseudo.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/style-first-letter-pseudo-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/valid-image-after-load.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/valid-image-after-load-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/valid-image-before-load.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/csspaint/valid-image-before-load-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-alpha.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-alpha-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-multiple.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-multiple-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-tiled.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/background-image-tiled-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-tiled.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-background-image-tiled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/geometry-border-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-constructor-error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-constructor-error-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-paint-error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-paint-error-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-pending-script.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalid-image-pending-script-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-background-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-border-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/invalidation-content-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/overdraw.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/overdraw-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint-arguments.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint-arguments-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint-function-arguments.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint-function-arguments-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-composite.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-composite-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-gradient.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-gradient-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-image-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-paths.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-paths-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-rects.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-rects-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-shadows.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-shadows-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-transform.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-transform-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/paint2d-zoom-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/parse-input-arguments.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/parse-input-arguments-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/registerPaint.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/registerPaint-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/generate-paint-style-logging.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/html5.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/paint-logging-green.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-geometry-logging.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-invalidation-logging.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-paint-helper.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/resources/test-runner-paint-worklet.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-background-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-background-image-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-before-pseudo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-before-pseudo-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-after-load.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-after-load-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-before-load.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/csspaint/valid-image-before-load-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/resources/run-after-layout-and-paint.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
nhiroki
+ikilpatrick@, +junov@ (owners of modules/csspaint/) Hi, could you review this? Thanks. https://codereview.chromium.org/2868003002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (left): ...
3 years, 7 months ago (2017-05-09 08:45:45 UTC) #5
nhiroki
Presubmit checkes failed with following errors: ** Presubmit ERRORS ** * The following files are ...
3 years, 7 months ago (2017-05-09 08:49:42 UTC) #8
nhiroki
Ping? :)
3 years, 7 months ago (2017-05-10 23:33:01 UTC) #9
nhiroki
On 2017/05/09 08:49:42, nhiroki wrote: > Presubmit checkes failed with following errors: > > ** ...
3 years, 7 months ago (2017-05-11 00:57:10 UTC) #12
nhiroki
Ping? (this is the last blocker to enabling module loading for PaintWorklet [*]) [*] https://codereview.chromium.org/2826313003/
3 years, 7 months ago (2017-05-12 00:21:06 UTC) #15
nhiroki
ikilpatrick@, junov@: I'm now back from OOO and resuming this work. Could you review this?
3 years, 7 months ago (2017-05-22 00:36:18 UTC) #18
nhiroki
+style-dev@, anyone can review this? Thank you.
3 years, 7 months ago (2017-05-23 10:53:55 UTC) #22
ikilpatrick
lgtm
3 years, 7 months ago (2017-05-24 03:39:42 UTC) #23
nhiroki
Thank you!
3 years, 7 months ago (2017-05-24 04:00:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868003002/40001
3 years, 7 months ago (2017-05-24 04:01:39 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 05:37:51 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a71bdb09d0b4e789a045820895ab...

Powered by Google App Engine
This is Rietveld 408576698