Change target+selector for block in InfoBarView

Change target+selector for block in InfoBarView

InfoBarView used a target and a selector for sending the information that a
link has been clicked. This is triggering a warning when compiling with ARC.
This CL changes this by using a block instead.

BUG=714060
Review-Url: https://codereview.chromium.org/2831293002
Cr-Commit-Position: refs/heads/master@{#466335}
Committed: https://chromium.googlesource.com/chromium/src/+/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc

[gambard, 2017-04-21 08:57:01]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-04-21 08:57:02]

PTAL.

[gambard, 2017-04-21 10:34:06]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 10:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 10:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 10:44:16]

Dry run: This issue passed the CQ dry run.

[jif, 2017-04-21 11:12:48]

lgtm

https://codereview.chromium.org/2831293002/diff/20001/ios/chrome/browser/ui/i...
File ios/chrome/browser/ui/infobars/infobar_view.h (right):

https://codereview.chromium.org/2831293002/diff/20001/ios/chrome/browser/ui/i...
ios/chrome/browser/ui/infobars/infobar_view.h:54: // |stringAsLink:|. |action|
is called when a link is clicked.
Can you explain what NSUInteger is? For example:

|action| is called when a link is clicked, with the tag associated with the link
passed as a parameter.

[gambard, 2017-04-21 11:34:05]

Thanks!

https://codereview.chromium.org/2831293002/diff/20001/ios/chrome/browser/ui/i...
File ios/chrome/browser/ui/infobars/infobar_view.h (right):

https://codereview.chromium.org/2831293002/diff/20001/ios/chrome/browser/ui/i...
ios/chrome/browser/ui/infobars/infobar_view.h:54: // |stringAsLink:|. |action|
is called when a link is clicked.
On 2017/04/21 11:12:48, jif wrote:
> Can you explain what NSUInteger is? For example:
> 
> |action| is called when a link is clicked, with the tag associated with the
link
> passed as a parameter.

Done.

[gambard, 2017-04-21 11:34:27]

gambard@chromium.org changed reviewers:
+ sdefresne@chromium.org

[gambard, 2017-04-21 11:34:27]

sdefresne@: PTAL.

[sdefresne, 2017-04-21 14:19:25]

lgtm

https://codereview.chromium.org/2831293002/diff/40001/ios/chrome/browser/info...
File ios/chrome/browser/infobars/confirm_infobar_controller.mm (right):

https://codereview.chromium.org/2831293002/diff/40001/ios/chrome/browser/info...
ios/chrome/browser/infobars/confirm_infobar_controller.mm:123: [self
infobarLinkDidPress:tag];
This block has a strong reference to "self". Thus "view" could be gaining a
strong reference to "self". Since -addLabel:target:action: also used to keep a
reference on "target", this does not change anything and the block is not
creating a cycle that did not exists before.

[gambard, 2017-04-21 14:41:43]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 14:42:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:51:35]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-04-21 14:54:48]

https://codereview.chromium.org/2831293002/diff/40001/ios/chrome/browser/info...
File ios/chrome/browser/infobars/confirm_infobar_controller.mm (right):

https://codereview.chromium.org/2831293002/diff/40001/ios/chrome/browser/info...
ios/chrome/browser/infobars/confirm_infobar_controller.mm:123: [self
infobarLinkDidPress:tag];
On 2017/04/21 14:19:24, sdefresne wrote:
> This block has a strong reference to "self". Thus "view" could be gaining a
> strong reference to "self". Since -addLabel:target:action: also used to keep a
> reference on "target", this does not change anything and the block is not
> creating a cycle that did not exists before.

Yes, I tried to keep the current behavior.

[gambard, 2017-04-21 14:54:52]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-04-21 14:54:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2831293002/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2017-04-21 14:55:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492786492598760,
"parent_rev": "4b7ff088f9cb7d536c0655300a5df2178b45307c", "commit_rev":
"d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc"}

[commit-bot: I haz the power, 2017-04-21 14:59:33]

Description was changed from

==========
Change target+selector for block in InfoBarView

InfoBarView used a target and a selector for sending the information that a
link has been clicked. This is triggering a warning when compiling with ARC.
This CL changes this by using a block instead.

BUG=714060
==========

to

==========
Change target+selector for block in InfoBarView

InfoBarView used a target and a selector for sending the information that a
link has been clicked. This is triggering a warning when compiling with ARC.
This CL changes this by using a block instead.

BUG=714060

Review-Url: https://codereview.chromium.org/2831293002
Cr-Commit-Position: refs/heads/master@{#466335}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7eb90bb8049854a8c77604a6fc7...
==========

[commit-bot: I haz the power, 2017-04-21 14:59:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d7eb90bb8049854a8c77604a6fc7...