Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: ios/chrome/browser/passwords/update_password_infobar_controller.mm

Issue 2831293002: Change target+selector for block in InfoBarView (Closed)
Patch Set: Address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/passwords/update_password_infobar_controller.h" 5 #import "ios/chrome/browser/passwords/update_password_infobar_controller.h"
6 6
7 #import "base/mac/objc_property_releaser.h" 7 #import "base/mac/objc_property_releaser.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "ios/chrome/browser/infobars/confirm_infobar_controller+protected.h" 10 #include "ios/chrome/browser/infobars/confirm_infobar_controller+protected.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // link. 55 // link.
56 if (_delegate->ShowMultipleAccounts()) { 56 if (_delegate->ShowMultipleAccounts()) {
57 base::string16 usernameLink = base::SysNSStringToUTF16([[view class] 57 base::string16 usernameLink = base::SysNSStringToUTF16([[view class]
58 stringAsLink:base::SysUTF16ToNSString(_delegate->selected_account()) 58 stringAsLink:base::SysUTF16ToNSString(_delegate->selected_account())
59 tag:kAccountTag]); 59 tag:kAccountTag]);
60 base::ReplaceFirstSubstringAfterOffset( 60 base::ReplaceFirstSubstringAfterOffset(
61 &messageText, 0, _delegate->selected_account(), usernameLink); 61 &messageText, 0, _delegate->selected_account(), usernameLink);
62 } 62 }
63 63
64 [view addLabel:base::SysUTF16ToNSString(messageText) 64 [view addLabel:base::SysUTF16ToNSString(messageText)
65 target:self 65 action:^(NSUInteger tag) {
66 action:@selector(infobarLinkDidPress:)]; 66 [self infobarLinkDidPress:tag];
67 }];
67 } 68 }
68 69
69 - (void)infobarLinkDidPress:(NSNumber*)tag { 70 - (void)infobarLinkDidPress:(NSUInteger)tag {
70 [super infobarLinkDidPress:tag]; 71 [super infobarLinkDidPress:tag];
71 if ([tag unsignedIntegerValue] != kAccountTag) 72 if (tag != kAccountTag)
72 return; 73 return;
73 74
74 UIViewController* baseViewController = 75 UIViewController* baseViewController =
75 [[UIApplication sharedApplication] keyWindow].rootViewController; 76 [[UIApplication sharedApplication] keyWindow].rootViewController;
76 self.selectorCoordinator = [[[SelectorCoordinator alloc] 77 self.selectorCoordinator = [[[SelectorCoordinator alloc]
77 initWithBaseViewController:baseViewController] autorelease]; 78 initWithBaseViewController:baseViewController] autorelease];
78 self.selectorCoordinator.delegate = self; 79 self.selectorCoordinator.delegate = self;
79 self.selectorCoordinator.options = 80 self.selectorCoordinator.options =
80 [NSOrderedSet orderedSetWithArray:_delegate->GetAccounts()]; 81 [NSOrderedSet orderedSetWithArray:_delegate->GetAccounts()];
81 self.selectorCoordinator.defaultOption = 82 self.selectorCoordinator.defaultOption =
82 base::SysUTF16ToNSString(_delegate->selected_account()); 83 base::SysUTF16ToNSString(_delegate->selected_account());
83 [self.selectorCoordinator start]; 84 [self.selectorCoordinator start];
84 } 85 }
85 86
86 #pragma mark SelectorCoordinatorDelegate 87 #pragma mark SelectorCoordinatorDelegate
87 88
88 - (void)selectorCoordinator:(SelectorCoordinator*)coordinator 89 - (void)selectorCoordinator:(SelectorCoordinator*)coordinator
89 didCompleteWithSelection:(NSString*)selection { 90 didCompleteWithSelection:(NSString*)selection {
90 _delegate->set_selected_account(base::SysNSStringToUTF16(selection)); 91 _delegate->set_selected_account(base::SysNSStringToUTF16(selection));
91 [self updateInfobarLabel:self.view]; 92 [self updateInfobarLabel:self.view];
92 } 93 }
93 94
94 @end 95 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698