Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2829223004: Rename GoogleLandingController to GoogleLandingViewController.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by OOTO until June 5th
Modified:
4 days, 10 hours ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl -pls.ping.after.24h., noyau+watch_chromium.org, ios-reviews+clean_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename GoogleLandingController to GoogleLandingViewController. BUG=694750

Patch Set 1 #

Patch Set 2 : Missing files #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1627 lines, -56 lines) Patch
M ios/chrome/app/spotlight/topsites_spotlight_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
D ios/chrome/browser/ui/ntp/google_landing_controller.h View 1 chunk +0 lines, -34 lines 0 comments Download
A + ios/chrome/browser/ui/ntp/google_landing_view_controller.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A ios/chrome/browser/ui/ntp/google_landing_view_controller.mm View 1 2 1 chunk +1525 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ntp/google_landing_view_controller_unittest.mm View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 6 (5 generated)
OOTO until June 5th
1 week, 1 day ago (2017-04-21 11:49:48 UTC) #2
PTAL, simple s/g on GoogleLandingController and google_landing_controller
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46