Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2782563003: Replace Clock with timeutils in AudioEncoder. (Closed)

Created:
3 years, 8 months ago by michaelt
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, kwiberg-webrtc, Andrew MacDonald, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace Clock with timeutils in AudioEncoder. BUG=webrtc:7398 Review-Url: https://codereview.webrtc.org/2782563003 Cr-Commit-Position: refs/heads/master@{#17732} Committed: https://chromium.googlesource.com/external/webrtc/+/92aef17cb23d59bdbcca1211c317970506502f34

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix common_audio_unittests. #

Patch Set 4 : Rebased #

Total comments: 4

Patch Set 5 : Respond to comment #

Patch Set 6 : Fix for failing unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -170 lines) Patch
M webrtc/common_audio/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/smoothing_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/common_audio/smoothing_filter.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M webrtc/common_audio/smoothing_filter_unittest.cc View 1 2 3 4 5 6 chunks +32 lines, -33 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 1 2 3 4 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 1 2 3 4 5 8 chunks +11 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h View 1 2 3 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc View 1 2 3 9 chunks +9 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc View 1 2 3 4 5 12 chunks +16 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 1 2 3 4 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 2 3 5 chunks +11 lines, -18 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 2 3 4 5 14 chunks +27 lines, -28 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 67 (43 generated)
michaelt
3 years, 8 months ago (2017-03-28 10:44:43 UTC) #3
michaelt
Hi i have rebased this.
3 years, 8 months ago (2017-04-03 12:09:45 UTC) #4
minyue-webrtc
cool! + Please update the title and description to say "Replace Clock with timeutils in ...
3 years, 8 months ago (2017-04-06 10:57:54 UTC) #13
michaelt
On 2017/04/06 10:57:54, minyue-webrtc wrote: > cool! > > + Please update the title and ...
3 years, 8 months ago (2017-04-06 11:30:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/40001
3 years, 8 months ago (2017-04-06 12:06:33 UTC) #17
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-06 12:06:35 UTC) #19
minyue-webrtc
lgtm
3 years, 8 months ago (2017-04-06 19:10:56 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/40001
3 years, 8 months ago (2017-04-06 19:11:02 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/176)
3 years, 8 months ago (2017-04-06 19:15:12 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/40001
3 years, 8 months ago (2017-04-07 06:29:49 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15877)
3 years, 8 months ago (2017-04-07 06:33:54 UTC) #30
minyue-webrtc
On 2017/04/07 06:33:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-07 09:48:11 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/60001
3 years, 8 months ago (2017-04-10 12:03:25 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15984)
3 years, 8 months ago (2017-04-10 12:08:16 UTC) #40
michaelt
@kwiberg@webrtc.org Hi could you take a look, to the common audio part of the CL ...
3 years, 8 months ago (2017-04-10 13:26:22 UTC) #42
kwiberg-webrtc
https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc File webrtc/common_audio/smoothing_filter_unittest.cc (right): https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc#newcode26 webrtc/common_audio/smoothing_filter_unittest.cc:26: std::unique_ptr<rtc::ScopedFakeClock> fake_clock; This doesn't look quite right. IIUC the ...
3 years, 8 months ago (2017-04-11 12:18:38 UTC) #43
michaelt
https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc File webrtc/common_audio/smoothing_filter_unittest.cc (right): https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc#newcode26 webrtc/common_audio/smoothing_filter_unittest.cc:26: std::unique_ptr<rtc::ScopedFakeClock> fake_clock; I think you are right that this ...
3 years, 8 months ago (2017-04-11 14:11:13 UTC) #44
kwiberg-webrtc
https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc File webrtc/common_audio/smoothing_filter_unittest.cc (right): https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc#newcode26 webrtc/common_audio/smoothing_filter_unittest.cc:26: std::unique_ptr<rtc::ScopedFakeClock> fake_clock; On 2017/04/11 14:11:13, michaelt wrote: > I ...
3 years, 8 months ago (2017-04-11 16:46:57 UTC) #45
michaelt
https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc File webrtc/common_audio/smoothing_filter_unittest.cc (right): https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoothing_filter_unittest.cc#newcode26 webrtc/common_audio/smoothing_filter_unittest.cc:26: std::unique_ptr<rtc::ScopedFakeClock> fake_clock; On 2017/04/11 16:46:57, kwiberg-webrtc wrote: > On ...
3 years, 8 months ago (2017-04-12 07:17:57 UTC) #46
kwiberg-webrtc
lgtm for common_audio
3 years, 8 months ago (2017-04-12 07:27:03 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/80001
3 years, 8 months ago (2017-04-12 09:20:18 UTC) #50
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/18153)
3 years, 8 months ago (2017-04-12 09:41:19 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782563003/120001
3 years, 8 months ago (2017-04-18 06:47:40 UTC) #64
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 07:11:54 UTC) #67
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/92aef17cb23d59bdbcca1211c...

Powered by Google App Engine
This is Rietveld 408576698