Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2779593002: [cc] Forward BeginFrameAcks through RWHVChildFrame. (Closed)

Created:
3 years, 9 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Sami, brianderson, enne (OOO), Fady Samuel
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[cc] Forward BeginFrameAcks through RWHVChildFrame. Passes on BeginFrameAcks from RenderWidgetHostViewChildFrame to CompositorFrameSinkSupport and adds a test for this. This is work towards unified BeginFrame acknowledgments, see: Tracking bug: https://crbug.com/697086 Design doc: http://bit.ly/beginframeacks BUG=697086, 646774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2779593002 Cr-Commit-Position: refs/heads/master@{#460054} Committed: https://chromium.googlesource.com/chromium/src/+/5c732104d0278822b4df84d76362f60d2929b037

Patch Set 1 : . #

Patch Set 2 : fix compile on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 2 chunks +49 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
Eric Seckler
Antoine, PTAL. Thanks! :)
3 years, 9 months ago (2017-03-27 10:32:04 UTC) #6
piman
lgtm
3 years, 8 months ago (2017-03-27 18:11:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779593002/40001
3 years, 8 months ago (2017-03-28 09:34:33 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 09:40:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5c732104d0278822b4df84d76362...

Powered by Google App Engine
This is Rietveld 408576698