Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor

Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor 

BUG=693975
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2778963002
Cr-Commit-Position: refs/heads/master@{#460047}
Committed: https://chromium.googlesource.com/chromium/src/+/ec7293736547e92e7f86ab52edebb469b9a5b93c

[yoichio, 2017-03-28 02:31:19]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 02:31:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-28 03:48:08]

Description was changed from

==========
createRangeFromSelectionEditor return EphemeralRange

BUG=693975
TEST=No change in behavior
==========

to

==========
Return EphemeralRange instead of Range in
DOMSelection::createRangeFromSelectionEditor 

BUG=693975
TEST=No change in behavior
==========

[yoichio, 2017-03-28 03:48:08]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:00:35]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-28 07:04:31]

lgtm

https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:227: if
(createRangeFromSelectionEditor().isNotNull())
nit: I prefer using "?:" as original

return createRangeFromSelectionEditor().isNotNull() ? 1 : 0;

[yoichio, 2017-03-28 08:59:40]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-03-28 08:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 09:20:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490691580345710, "parent_rev":
"2a98557c9c9b4456f41e54bca1a5433b0a73c2c5", "commit_rev":
"ec7293736547e92e7f86ab52edebb469b9a5b93c"}

[commit-bot: I haz the power, 2017-03-28 09:21:41]

Description was changed from

==========
Return EphemeralRange instead of Range in
DOMSelection::createRangeFromSelectionEditor 

BUG=693975
TEST=No change in behavior
==========

to

==========
Return EphemeralRange instead of Range in
DOMSelection::createRangeFromSelectionEditor 

BUG=693975
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2778963002
Cr-Commit-Position: refs/heads/master@{#460047}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec7293736547e92e7f86ab52edeb...
==========

[commit-bot: I haz the power, 2017-03-28 09:21:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec7293736547e92e7f86ab52edeb...

[yoichio, 2017-03-28 09:32:51]

https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:227: if
(createRangeFromSelectionEditor().isNotNull())
On 2017/03/28 07:04:31, yosin_UTC9 wrote:
> nit: I prefer using "?:" as original
> 
> return createRangeFromSelectionEditor().isNotNull() ? 1 : 0;
New early-return follows above early returns of 1 or 0.