Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: third_party/WebKit/Source/core/editing/DOMSelection.h

Issue 2778963002: Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 bool isBaseFirstInSelection() const; 115 bool isBaseFirstInSelection() const;
116 const Position& anchorPosition() const; 116 const Position& anchorPosition() const;
117 117
118 Node* shadowAdjustedNode(const Position&) const; 118 Node* shadowAdjustedNode(const Position&) const;
119 unsigned shadowAdjustedOffset(const Position&) const; 119 unsigned shadowAdjustedOffset(const Position&) const;
120 120
121 bool isValidForPosition(Node*) const; 121 bool isValidForPosition(Node*) const;
122 122
123 void addConsoleError(const String& message); 123 void addConsoleError(const String& message);
124 Range* primaryRangeOrNull() const; 124 Range* primaryRangeOrNull() const;
125 Range* createRangeFromSelectionEditor() const; 125 EphemeralRange createRangeFromSelectionEditor() const;
126 126
127 bool isSelectionOfDocument() const; 127 bool isSelectionOfDocument() const;
128 void cacheRangeIfSelectionOfDocument(Range*) const; 128 void cacheRangeIfSelectionOfDocument(Range*) const;
129 Range* documentCachedRange() const; 129 Range* documentCachedRange() const;
130 void clearCachedRangeIfSelectionOfDocument(); 130 void clearCachedRangeIfSelectionOfDocument();
131 131
132 Member<const TreeScope> m_treeScope; 132 Member<const TreeScope> m_treeScope;
133 }; 133 };
134 134
135 } // namespace blink 135 } // namespace blink
136 136
137 #endif // DOMSelection_h 137 #endif // DOMSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698