Start aligning BackgroundFetchRequestInfo with the passed in request object.

Start aligning BackgroundFetchRequestInfo with the passed in request object.

This CL makes two changes to BackgroundFetchRequestInfo. First, it adds
a ServiceWorkerFetchRequest object which copies the value passed in from
the Mojo call and will be serialized out as part of storing the request.
As part of this, the old url_ member is removed, since it is replaced by
the FetchRequest's url attribute.

The second change is that the tag_ attribute on the RequestInfo isxi
removed. It was a legacy from when a request tracked the entire job, and
wasn't used.

BUG=692540
Review-Url: https://codereview.chromium.org/2778793002
Cr-Commit-Position: refs/heads/master@{#460048}
Committed: https://chromium.googlesource.com/chromium/src/+/98c614330c5ea34ff43692394e63dcb2168fe54b

[harkness, 2017-03-27 13:37:59]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-03-27 13:40:15]

lgtm

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_request_info.h (right):

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_request_info.h:32: const GURL&
GetUrl() const;
GetURL for consistency with url::Origin (which our code also uses plenty)

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_request_info.h:62: std::string
guid_;
do we still need this?

[harkness, 2017-03-27 16:44:00]

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_request_info.h (right):

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_request_info.h:32: const GURL&
GetUrl() const;
On 2017/03/27 13:40:15, Peter Beverloo wrote:
> GetURL for consistency with url::Origin (which our code also uses plenty)

Done.

https://codereview.chromium.org/2778793002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_request_info.h:62: std::string
guid_;
On 2017/03/27 13:40:15, Peter Beverloo wrote:
> do we still need this?

This should be replaced by request_index, but I thought that should be in a
separate CL probably at the same time the "GetNextRequest" is updated.

[harkness, 2017-03-27 22:19:33]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-03-27 22:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2778793002/#ps20001
(title: "s/GetUrl/GetURL/g")

[commit-bot: I haz the power, 2017-03-27 22:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:25:12]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[harkness, 2017-03-28 07:27:04]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-03-28 07:27:04]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2778793002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-28 07:27:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 09:22:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490686024088580,
"parent_rev": "ec7293736547e92e7f86ab52edebb469b9a5b93c", "commit_rev":
"98c614330c5ea34ff43692394e63dcb2168fe54b"}

[commit-bot: I haz the power, 2017-03-28 09:23:32]

Description was changed from

==========
Start aligning BackgroundFetchRequestInfo with the passed in request object.

This CL makes two changes to BackgroundFetchRequestInfo. First, it adds
a ServiceWorkerFetchRequest object which copies the value passed in from
the Mojo call and will be serialized out as part of storing the request.
As part of this, the old url_ member is removed, since it is replaced by
the FetchRequest's url attribute.

The second change is that the tag_ attribute on the RequestInfo isxi
removed. It was a legacy from when a request tracked the entire job, and
wasn't used.

BUG=692540
==========

to

==========
Start aligning BackgroundFetchRequestInfo with the passed in request object.

This CL makes two changes to BackgroundFetchRequestInfo. First, it adds
a ServiceWorkerFetchRequest object which copies the value passed in from
the Mojo call and will be serialized out as part of storing the request.
As part of this, the old url_ member is removed, since it is replaced by
the FetchRequest's url attribute.

The second change is that the tag_ attribute on the RequestInfo isxi
removed. It was a legacy from when a request tracked the entire job, and
wasn't used.

BUG=692540

Review-Url: https://codereview.chromium.org/2778793002
Cr-Commit-Position: refs/heads/master@{#460048}
Committed:
https://chromium.googlesource.com/chromium/src/+/98c614330c5ea34ff43692394e63...
==========

[commit-bot: I haz the power, 2017-03-28 09:23:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98c614330c5ea34ff43692394e63...