DescriptionIntroduce SelectSettings algorithm for MediaStream video tracks.
This CL also:
* Renames functions and types related to selecting settings, dropping
"Source" from the name, since now they also deal with track settings.
* Introduces a VideoTrackAdapterSettings struct to pass arguments to
VideoTrackAdapter and to return track settings in a more convenient
manner.
* Use a single class VideoCaptureSettings for the results of both
content and device capture. They differed only in the facing_mode
field.
* The default width and height in
ResolutionSet::SelectClosestPointToIdeal are passed as parameters
instead of using MediaStreamVideoSource constants. This gives more
flexibility, such as allowing the use of source settings as defaults.
* Makes default width and height constants for content capture public.
This is a first step towards better defaults for screen capture. See
http://crbug.com/257097.
* Reimplements the internal ConstrainedFormat class in
media_stream_constraints_util_video_device.cc so in terms of
ResolutionSet and NumericRangeSet. This removes code that is largely
duplicated and facilitates integration with the code that computes
track settings.
* Replaces rtc::Optional with base::Optional.
* Makes minor changes to be more consistent with other parts of the
codebase (e.g., some constexpr changed to const), or to better
express intent.
* Fixes minor lint issues in existing source files.
BUG=657733
Review-Url: https://codereview.chromium.org/2777703002
Cr-Commit-Position: refs/heads/master@{#460403}
Committed: https://chromium.googlesource.com/chromium/src/+/eff69cf4c3028e0bb4e15c78b137c6bb26966974
Patch Set 1 #Patch Set 2 : merge Content and Device result classes #
Total comments: 25
Patch Set 3 : address hbos' comments #Patch Set 4 : static asserts #Messages
Total messages: 45 (37 generated)
|