Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2765193002:
Prototype for the new UI for the Safe Browsing Subresource Filter. (Closed)
|
Created:
3 years, 9 months ago by melandory Modified:
3 years, 8 months ago CC:
chromium-reviews, srahim+watch_chromium.org, agrieve+watch_chromium.org, subresource-filter-reviews_chromium.org, dfalcantara+watch_chromium.org, shivanisha Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrototype for the new UI for the Safe Browsing Subresource Filter.
This CL adds the prototype for the new UI for the Subresource Filter for
the Android platform. New UI consists of the small version of the
infobar and the "Details" link. When the link is pressed full infobar
with detailed text and the action buttons appears.
The bug contains screenshots for the UI implemeted in this CL and mocks.
Note that, this CL is the first step towards, but does not yet implement
the UI as in mocks.
BUG=689992
Review-Url: https://codereview.chromium.org/2765193002
Cr-Commit-Position: refs/heads/master@{#460085}
Committed: https://chromium.googlesource.com/chromium/src/+/9b44551e3f90c894305a6ec32bc1ae1b7e8f3f21
Patch Set 1 : cleanup #Patch Set 2 : rebased #Patch Set 3 : rebase for real? #Patch Set 4 : make analyzer happy #
Total comments: 8
Patch Set 5 : comments #Messages
Total messages: 68 (57 generated)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
melandory@chromium.org changed reviewers: + miguelg@chromium.org
miguelg@ PTAL at all changes in chrome/ engedy@: PTAL at all changes in components/
melandory@chromium.org changed reviewers: + engedy@chromium.org
engedy@: PTAL at all changes in components/
Patchset #1 (id:1) has been deleted
Description was changed from ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted ion current CL and mocks. BUG=689992 experimental infobar ========== to ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. BUG=689992 experimental infobar ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Description was changed from ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. BUG=689992 experimental infobar ========== to ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL doesn't have a goal to implement the UI as in mocks. BUG=689992 experimental infobar ==========
Description was changed from ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL doesn't have a goal to implement the UI as in mocks. BUG=689992 experimental infobar ========== to ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL doesn't have a goal to implement the UI as in mocks. BUG=689992 ==========
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
components/* LGTM.
Description was changed from ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL doesn't have a goal to implement the UI as in mocks. BUG=689992 ========== to ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL is the first step towards, but does not yet implement the UI as in mocks. BUG=689992 ==========
csharrison@chromium.org changed reviewers: + csharrison@chromium.org
+shivanisha cc
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
friendly ping
I am OOO until april 3d can you find another reviewer? On Mar 24, 2017 10:11, <melandory@chromium.org> wrote: > friendly ping > > https://codereview.chromium.org/2765193002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
melandory@chromium.org changed reviewers: + dfalcantara@chromium.org
PTAL at all changes in chrome/
lgtm % comments https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java (right): https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:23: private Boolean mShowExplanation; use a regular boolean instead of Boolean https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:40: mShowExplanation = false; this is false by default in Java https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:49: nit: remove extra newline https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:2786: </message> Pull this out into a common string and shove it at the top "generic" section. We've already got "Details" showing up as IDS_PAGE_INFO_DETAILS_LINK, too.
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:100001) has been deleted
Patchset #5 (id:120001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java (right): https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:23: private Boolean mShowExplanation; On 2017/03/24 21:16:13, dfalcantara (load balance plz) wrote: > use a regular boolean instead of Boolean Done. https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:40: mShowExplanation = false; On 2017/03/24 21:16:13, dfalcantara (load balance plz) wrote: > this is false by default in Java Done. https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/infobar/SubresourceFilterExperimentalInfoBar.java:49: On 2017/03/24 21:16:13, dfalcantara (load balance plz) wrote: > nit: remove extra newline Done. https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2765193002/diff/80001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:2786: </message> On 2017/03/24 21:16:13, dfalcantara (load balance plz) wrote: > Pull this out into a common string and shove it at the top "generic" section. > We've already got "Details" showing up as IDS_PAGE_INFO_DETAILS_LINK, too. Done.
Patchset #5 (id:140001) has been deleted
Patchset #5 (id:160001) has been deleted
The CQ bit was checked by melandory@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2765193002/#ps180001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 180001, "attempt_start_ts": 1490708912907030,
"parent_rev": "c15fed41a2b548c5aaa5959c8a0c9498f4f38617", "commit_rev":
"9b44551e3f90c894305a6ec32bc1ae1b7e8f3f21"}
Message was sent while issue was closed.
Description was changed from ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL is the first step towards, but does not yet implement the UI as in mocks. BUG=689992 ========== to ========== Prototype for the new UI for the Safe Browsing Subresource Filter. This CL adds the prototype for the new UI for the Subresource Filter for the Android platform. New UI consists of the small version of the infobar and the "Details" link. When the link is pressed full infobar with detailed text and the action buttons appears. The bug contains screenshots for the UI implemeted in this CL and mocks. Note that, this CL is the first step towards, but does not yet implement the UI as in mocks. BUG=689992 Review-Url: https://codereview.chromium.org/2765193002 Cr-Commit-Position: refs/heads/master@{#460085} Committed: https://chromium.googlesource.com/chromium/src/+/9b44551e3f90c894305a6ec32bc1... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:180001) as https://chromium.googlesource.com/chromium/src/+/9b44551e3f90c894305a6ec32bc1... |
