Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2764673002: Embedded media: Rotate to fullscreen

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by shaktisahu
Modified:
4 months, 3 weeks ago
Reviewers:
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, agrieve+watch_chromium.org, blink-reviews, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Embedded media: Rotate to fullscreen This CL adds the following changes for downloaded video playback: 1 - When orientation switches to landscape, video goes fullscreen. 2 - Hide media controls at playback start and after enter/exit fullscreen. 3 - Hiding exit fullscreen toast after entering fullscreen. BUG=698353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 3 chunks +53 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/MediaDocument.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 2 chunks +2 lines, -3 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 1 (1 generated)
shaktisahu
4 months, 3 weeks ago (2017-03-30 05:26:13 UTC) #1
Message was sent while issue was closed.
Description was changed from

==========
Embedded media: Rotate to fullscreen

This CL adds the following changes for downloaded video playback:

1 - When orientation switches to landscape, video goes fullscreen.
2 - Hide media controls at playback start and after enter/exit fullscreen.
3 - Hiding exit fullscreen toast after entering fullscreen.

BUG=698353
==========

to

==========
Embedded media: Rotate to fullscreen

This CL adds the following changes for downloaded video playback:

1 - When orientation switches to landscape, video goes fullscreen.
2 - Hide media controls at playback start and after enter/exit fullscreen.
3 - Hiding exit fullscreen toast after entering fullscreen.

BUG=698353
==========
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b