Issue 2764673002: Embedded media: Rotate to fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2764673002: Embedded media: Rotate to fullscreen

Created:
3 years, 9 months ago by shaktisahu

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, agrieve+watch_chromium.org, blink-reviews, Srirama

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Embedded media: Rotate to fullscreen This CL adds the following changes for downloaded video playback: 1 - When orientation switches to landscape, video goes fullscreen. 2 - Hide media controls at playback start and after enter/exit fullscreen. 3 - Hiding exit fullscreen toast after entering fullscreen. BUG=698353

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -6 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/android/tab_android.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/android/tab_android.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLVideoElement.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLVideoElement.cpp	View	3 chunks	+53 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/html/MediaDocument.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControls.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

shaktisahu

3 years, 8 months ago (2017-03-30 05:26:13 UTC) #1

Message was sent while issue was closed.

Description was changed from

==========
Embedded media: Rotate to fullscreen

This CL adds the following changes for downloaded video playback:

1 - When orientation switches to landscape, video goes fullscreen.
2 - Hide media controls at playback start and after enter/exit fullscreen.
3 - Hiding exit fullscreen toast after entering fullscreen.

BUG=698353
==========

to

==========
Embedded media: Rotate to fullscreen

This CL adds the following changes for downloaded video playback:

1 - When orientation switches to landscape, video goes fullscreen.
2 - Hide media controls at playback start and after enter/exit fullscreen.
3 - Hiding exit fullscreen toast after entering fullscreen.

BUG=698353
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages