third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp - Issue 2764313002: Move plugins to be stored in HTMLPlugInElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)

Patch Set: Update comments about duplicating code Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/PluginDocument.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | third_party/WebKit/Source/core/paint/PartPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp

index 4aa26d6277face07cd9a2f033cb1ae5a0682a99f..4774e8f5257064631ba70c882fcf0373fa00d680 100644

--- a/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp

@@ -16,9 +16,9 @@ EmbeddedObjectPaintInvalidator::invalidatePaintIfNeeded() {

BoxPaintInvalidator(m_embeddedObject, m_context)

.invalidatePaintIfNeeded();

- FrameViewBase* frameViewBase = m_embeddedObject.frameViewBase();

- if (frameViewBase && frameViewBase->isPluginView())

- toPluginView(frameViewBase)->invalidatePaintIfNeeded();

+ PluginView* plugin = m_embeddedObject.plugin();

+ if (plugin)

+ plugin->invalidatePaintIfNeeded();

return reason;

}