Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Update comments about duplicating code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index aff5a7e32eb2a4fad4eb8a2269433fe933ad360c..2c22ee1b7e248202f83d0b8ebeed53e80506ca06 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -994,14 +994,10 @@ Region ScrollingCoordinator::computeShouldHandleScrollGestureOnMainThreadRegion(
}
}
- if (const FrameView::ChildrenSet* children = frameView->children()) {
- for (const Member<FrameViewBase>& child : *children) {
- if (!(*child).isPluginView())
- continue;
-
- PluginView* pluginView = toPluginView(child.get());
- if (pluginView->wantsWheelEvents()) {
- IntRect box = frameView->convertToRootFrame(pluginView->frameRect());
+ if (const FrameView::PluginsSet* plugins = frameView->plugins()) {
+ for (const Member<PluginView>& plugin : *plugins) {
+ if (plugin->wantsWheelEvents()) {
+ IntRect box = frameView->convertToRootFrame(plugin->frameRect());
shouldHandleScrollGestureOnMainThreadRegion.unite(box);
}
}

Powered by Google App Engine
This is Rietveld 408576698