|
|
Created:
3 years, 9 months ago by shend Modified:
3 years, 9 months ago Reviewers:
alancutter (OOO until 2018) CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify handling of names in make_computed_style_base.py.
There is a lot of duplicate code in make_computed_style_base.py used to
handle names. This patch refactors the code so that the Field class
handles most of the naming logic.
BUG=628043
Review-Url: https://codereview.chromium.org/2762573005
Cr-Commit-Position: refs/heads/master@{#458906}
Committed: https://chromium.googlesource.com/chromium/src/+/a0ca178033ce1a45919921fa67a050b808d706de
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebaes #Messages
Total messages: 33 (27 generated)
shend@chromium.org changed reviewers: + alancutter@chromium.org
Hi Alan, this is the other part of the split CL, PTAL
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2762573005/#ps120001 (title: "Rebaes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490159578006480, "parent_rev": "6a1a664c21c7583874f21311f5955c70b317f121", "commit_rev": "7e485f0a4b8146e43b22c8f9b40a1bb2ecda5186"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490221979046900, "parent_rev": "0c664a465317526aecb1c454d5ae7b77a0a0b5b9", "commit_rev": "a0ca178033ce1a45919921fa67a050b808d706de"}
Message was sent while issue was closed.
Description was changed from ========== Simplify handling of names in make_computed_style_base.py. There is a lot of duplicate code in make_computed_style_base.py used to handle names. This patch refactors the code so that the Field class handles most of the naming logic. BUG=628043 ========== to ========== Simplify handling of names in make_computed_style_base.py. There is a lot of duplicate code in make_computed_style_base.py used to handle names. This patch refactors the code so that the Field class handles most of the naming logic. BUG=628043 Review-Url: https://codereview.chromium.org/2762573005 Cr-Commit-Position: refs/heads/master@{#458906} Committed: https://chromium.googlesource.com/chromium/src/+/a0ca178033ce1a45919921fa67a0... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/a0ca178033ce1a45919921fa67a0... |