Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2761673007: [autoroll] cache commit_metadata operations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by iannucci
Modified:
5 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[autoroll] cache commit_metadata operations. These metadata operations happen hundreds or thousands of times ( quadratically more for each potential roll candidate). Caching them should reduce the amount of time for the recipe roller to do its job. R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2761673007 Committed: https://github.com/luci/recipes-py/commit/fb61dcf4145be9d98f85d02af72a498f09782800

Patch Set 1 #

Patch Set 2 : remove print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M recipe_engine/fetch.py View 1 5 chunks +29 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (7 generated)
iannucci
5 months ago (2017-03-20 22:57:55 UTC) #1
nodir
lgtm
5 months ago (2017-03-20 23:30:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761673007/20001
5 months ago (2017-03-20 23:32:15 UTC) #8
commit-bot: I haz the power
5 months ago (2017-03-20 23:35:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/fb61dcf4145be9d98f85d02af72a498f097...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b