Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2759203003: Landing Recent QUIC changes until Thu Mar 16 17:24:53 2017 +0000 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Ryan Hamilton
Modified:
5 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until Thu Mar 16 17:24:53 2017 +0000 Add a QUIC BBR ack aggregation mode which measures the number of bytes acknowledged faster than the max bandwidth. Protected by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes. De-flakes and re-enables BbrSenderTest::SimpleTransfer2RTTStartup. Merge internal change: 150335661 https://codereview.chromium.org/2764653002/ Read and write connection ID (represented as uint64_t) in network byte order (big endian). Protected by FLAGS_quic_restart_flag_quic_big_endian_connection_id. Merge internal change: 150218161 https://codereview.chromium.org/2761973002/ Review-Url: https://codereview.chromium.org/2759203003 Cr-Commit-Position: refs/heads/master@{#458308} Committed: https://chromium.googlesource.com/chromium/src/+/6b9ac5c7d7b50d5e419eb9aadc8a52497b3fecb5

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : truncation #

Patch Set 4 : *facepalm* #

Patch Set 5 : float #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2143 lines, -193 lines) Patch
M net/quic/core/congestion_control/bbr_sender.h View 3 chunks +17 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 4 chunks +37 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 1 2 3 4 2 chunks +70 lines, -3 lines 0 comments Download
M net/quic/core/quic_data_reader.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 1 2 3 2 chunks +26 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 90 chunks +1939 lines, -186 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 25 (16 generated)
Ryan Hamilton
5 months ago (2017-03-20 22:27:57 UTC) #2
Jana
lgtm
5 months ago (2017-03-20 22:50:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759203003/40001
5 months ago (2017-03-20 23:12:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759203003/60001
5 months ago (2017-03-20 23:17:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/404332)
5 months ago (2017-03-20 23:52:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759203003/80001
5 months ago (2017-03-21 00:10:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/253986)
5 months ago (2017-03-21 01:49:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759203003/80001
5 months ago (2017-03-21 02:46:28 UTC) #22
commit-bot: I haz the power
5 months ago (2017-03-21 04:14:41 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6b9ac5c7d7b50d5e419eb9aadc8a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b