|
|
DescriptionRun FileSelectHelper::ProcessSelectedFilesMac in parallel in TaskScheduler.
Previously, this task was posted to the FILE_USER_BLOCKING thread
which is being deprecated.
BUG=689520
Review-Url: https://codereview.chromium.org/2679993002
Cr-Commit-Position: refs/heads/master@{#450331}
Committed: https://chromium.googlesource.com/chromium/src/+/7b90f697aaa909eac016f0217f690fc6e267c2f9
Patch Set 1 #Patch Set 2 : self-review #Patch Set 3 : include #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + erikchen@chromium.org
PTAL Note: When tasks were posted to the FILE_USER_BLOCKING, they could not run in parallel with other FILE_USER_BLOCKING tasks. Now they can. I don't think this is a problem, but please let me know if you think I'm wrong.
On 2017/02/07 15:28:10, fdoray wrote: > PTAL > > Note: When tasks were posted to the FILE_USER_BLOCKING, they could not run in > parallel with other FILE_USER_BLOCKING tasks. Now they can. I don't think this > is a problem, but please let me know if you think I'm wrong. ping
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
fdoray@chromium.org changed reviewers: + jochen@chromium.org
PTAL
jochen@: PTAL
lgtm
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from erikchen@chromium.org Link to the patchset: https://codereview.chromium.org/2679993002/#ps40001 (title: "include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487073485794320, "parent_rev": "ba86e8b1570210b191884e1c2534a2844aeac42e", "commit_rev": "7b90f697aaa909eac016f0217f690fc6e267c2f9"}
Message was sent while issue was closed.
Description was changed from ========== Run FileSelectHelper::ProcessSelectedFilesMac in parallel in TaskScheduler. Previously, this task was posted to the FILE_USER_BLOCKING thread which is being deprecated. BUG=689520 ========== to ========== Run FileSelectHelper::ProcessSelectedFilesMac in parallel in TaskScheduler. Previously, this task was posted to the FILE_USER_BLOCKING thread which is being deprecated. BUG=689520 Review-Url: https://codereview.chromium.org/2679993002 Cr-Commit-Position: refs/heads/master@{#450331} Committed: https://chromium.googlesource.com/chromium/src/+/7b90f697aaa909eac016f0217f69... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7b90f697aaa909eac016f0217f69...
Message was sent while issue was closed.
gab@chromium.org changed reviewers: + gab@chromium.org
Message was sent while issue was closed.
To comment on file_select_helper.h still mentions that ProcessSelectedFilesMac() should be called on the FILE_USER_BLOCKING thread (which is no more). Shouldn't these have been migrated to USER_BLOCKING priority? Either way, need to cleanup comment.
Message was sent while issue was closed.
ping Le jeu. 10 août 2017 13 h 24, <gab@chromium.org> a écrit : > To comment on file_select_helper.h still mentions that > ProcessSelectedFilesMac() > should be called on the FILE_USER_BLOCKING thread (which is no more). > > Shouldn't these have been migrated to USER_BLOCKING priority? Either way, > need > to cleanup comment. > > https://codereview.chromium.org/2679993002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |