Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 541343004: WebRTC: Pass WebRTC revision to perf dashboard for FYI bots. (Closed)

Created:
6 years, 3 months ago by kjellander_chromium
Modified:
3 years, 2 months ago
Reviewers:
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

WebRTC: Pass WebRTC revision to perf dashboard for FYI bots. When recipes was deployed, the "r_webrtc_rev" property passed to runtest.py was lost, causing the WebRTC revision no longer being passed to the Chrome perf dashboard. This only affected the Chromium WebRTC FYI bots, that builds Chromium with ToT WebRTC. Previously it was always parsed at https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/slave/chromium_commands.py&q=got_webrtc_revision&sq=package:chromium&type=cs BUG=382370 TEST=Ran a build with a local master+slave

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -14 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 3 chunks +13 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.py View 1 2 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_Builder__dbg_.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_GN.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_GN__dbg_.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_Tests__dbg___JB_Nexus7_2_.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Android_Tests__dbg___KK_Nexus5_.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Linux.json View 1 6 chunks +20 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Linux_GN.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Linux_GN__dbg_.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Mac.json View 1 6 chunks +20 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Win7_Tester.json View 1 6 chunks +20 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Win7_Tester_periodic_triggered.json View 1 6 chunks +20 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_WinXP_Tester.json View 1 6 chunks +20 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Win_Builder.json View 1 4 chunks +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/chromium.expected/chromium_webrtc_fyi_Win_Builder_periodic_triggered.json View 1 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
kjellander_chromium
3 years, 2 months ago (2017-09-29 07:08:46 UTC) #1 
Description was changed from

==========
WebRTC: Pass WebRTC revision to perf dashboard for FYI bots.

When recipes was deployed, the "r_webrtc_rev" property passed to
runtest.py was lost, causing the WebRTC revision no longer being
passed to the Chrome perf dashboard. This only affected the
Chromium WebRTC FYI bots, that builds Chromium with ToT WebRTC.

Previously it was always parsed at
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

BUG=382370
TEST=Ran a build with a local master+slave
==========

to

==========
WebRTC: Pass WebRTC revision to perf dashboard for FYI bots.

When recipes was deployed, the "r_webrtc_rev" property passed to
runtest.py was lost, causing the WebRTC revision no longer being
passed to the Chrome perf dashboard. This only affected the
Chromium WebRTC FYI bots, that builds Chromium with ToT WebRTC.

Previously it was always parsed at
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

BUG=382370
TEST=Ran a build with a local master+slave
==========

Powered by Google App Engine
This is Rietveld 408576698