Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm

Issue 3013123002: Remove unnecessary audio references in PeerConnectionFactory
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/android/src/jni/pc/peerconnectionfactory_jni.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 NSAssert(result, @"Failed to start worker thread."); 103 NSAssert(result, @"Failed to start worker thread.");
104 104
105 _signalingThread = rtc::Thread::Create(); 105 _signalingThread = rtc::Thread::Create();
106 result = _signalingThread->Start(); 106 result = _signalingThread->Start();
107 NSAssert(result, @"Failed to start signaling thread."); 107 NSAssert(result, @"Failed to start signaling thread.");
108 #ifdef HAVE_NO_MEDIA 108 #ifdef HAVE_NO_MEDIA
109 _nativeFactory = webrtc::CreateModularPeerConnectionFactory( 109 _nativeFactory = webrtc::CreateModularPeerConnectionFactory(
110 _networkThread.get(), 110 _networkThread.get(),
111 _workerThread.get(), 111 _workerThread.get(),
112 _signalingThread.get(), 112 _signalingThread.get(),
113 nullptr, // default_adm
114 nullptr, // audio_encoder_factory
115 nullptr, // audio_decoder_factory
116 nullptr, // video_encoder_factory 113 nullptr, // video_encoder_factory
117 nullptr, // video_decoder_factory 114 nullptr, // video_decoder_factory
118 nullptr, // audio_mixer
119 std::unique_ptr<cricket::MediaEngineInterface>(), 115 std::unique_ptr<cricket::MediaEngineInterface>(),
120 std::unique_ptr<webrtc::CallFactoryInterface>(), 116 std::unique_ptr<webrtc::CallFactoryInterface>(),
121 std::unique_ptr<webrtc::RtcEventLogFactoryInterface>()); 117 std::unique_ptr<webrtc::RtcEventLogFactoryInterface>());
122 #else 118 #else
123 // Ownership of encoder/decoder factories is passed on to the 119 // Ownership of encoder/decoder factories is passed on to the
124 // peerconnectionfactory, that handles deleting them. 120 // peerconnectionfactory, that handles deleting them.
125 _nativeFactory = webrtc::CreatePeerConnectionFactory(_networkThread.get(), 121 _nativeFactory = webrtc::CreatePeerConnectionFactory(_networkThread.get(),
126 _workerThread.get(), 122 _workerThread.get(),
127 _signalingThread.get(), 123 _signalingThread.get(),
128 nullptr, // audio devi ce module 124 nullptr, // audio devi ce module
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 _hasStartedAecDump = _nativeFactory->StartAecDump(fd, maxSizeInBytes); 213 _hasStartedAecDump = _nativeFactory->StartAecDump(fd, maxSizeInBytes);
218 return _hasStartedAecDump; 214 return _hasStartedAecDump;
219 } 215 }
220 216
221 - (void)stopAecDump { 217 - (void)stopAecDump {
222 _nativeFactory->StopAecDump(); 218 _nativeFactory->StopAecDump();
223 _hasStartedAecDump = NO; 219 _hasStartedAecDump = NO;
224 } 220 }
225 221
226 @end 222 @end
OLDNEW
« no previous file with comments | « sdk/android/src/jni/pc/peerconnectionfactory_jni.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698